Omveer Singh authored 2 years ago and Omveer_Singh committed 2 years ago

MQ/monitor/CMakeLists.txt: Boost added as dependency
algo/data/CMakeLists.txt: modified in Modern CMake
algo/test/CMakeLists: modified in Modern CMake
core/data/test/global/CMakeLists.txt: Unnecessary dependencies removed and added required dependencies
core/data/test/psd/CMakeLists.txt: Unnecessary dependencies removed
core/detectors/trd/CMakeLists.txt: TMVA dependency change to ROOT::TMVA

Omveer Singh authored 2 years ago and Omveer_Singh committed 2 years ago

Gtest and GtestMain Target created which depend on GTEST target

Remaining files which haven't been changed in modern cmake.
 MQ/monitor : Transition in Modern CMake
 core/data/test: Transition to Modern CMake
 reco/qa: Transition to Modern CMake
 tutorial/TaskToAlgo: Transition to modern CMake

CMakeList.txt files are modified according to modern CMake.
generate_cbm_executable() macro is used to make executable.
Imported targets of each package are used as dependencies.

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

Linking the MQ TSA  binaries on Debian11 need an additional boost library as
well as a reordering of the link libraries.

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

=> needed to collect histo and canvases from multiple instances of the devices (e.g. multiple nodes) in a single histo server
=> Same cannot easily be in processing classes like Unpack and BuildEvent as both name and folder need to be changed to avoid collisions

    - Fix to the performance plots of the DigiEventSink by changing the logic to Profile or new counts addition
    - Add option for DigiEvent I/O between builders and Sink

- Evolution of the full TS buffer size as function of device runtime
- Evolution of the missed TS buffer size as function of device runtime
- Evolution of the Processed full TS count as function of device runtime
- Evolution of the Processed missing TS count as function of device runtime
- Evolution of the Total processed TS count as function of device runtime
- Evolution of the Processed events count as function of device runtime

[MQ] in DigiEventSink, add flag to control Missing TS empty writing if consecutive check is ON, false by default

- The check for consecutive TS indices was still called when receiving Missing TS Data messages even if the bypass flag was set
  => Surround the call with proper if condition
- The range when taking the digis data out of the unpacked timeslice to the DigiEvent was missing the last digi for all detectors
  => Increment the stop iterator to make sure it is included
- In rare case, the device can be pulled down before the Init method is called/finished, which led to a segfault
  => add an InitDone flag + use it to control delete operations in the destructor

- Bring in new mapping setter from 819c026f
- More Default time offsets values based on RunId, Nickel ones are relative to BMon instead of TOF

- Add option to skip the emission of the built events (and unpacked TS) on the ZMQ output
- Fix wrong type for the MaxNb parameter (signed as default is -1)
- Fix potential segfaults in destructor

- Add BMon Unpack/Monitor device
- Add possibility to request from the source the start time of the first TS

- In CbmDeviceUnpackTofCri, get the TS start time directly from the timeslice and pass it to the BuildInt method, instead of some roundabout way with the algo
- In CbmDeviceUnpackTofCri, use the native pointer interface of the Algo to set the parameter pointer, brings more checks + avoid exposing internal methods

Jan de Cuveland authored 2 years ago and Administrator committed 2 years ago

- fles_ipc -> external::fles_ipc
- fles_logging -> external::fles_logging
- IPC_INCLUDE_DIRECTORY -> FLES_IPC_INCLUDE_DIRECTORY

Fix deprecation warnings about upercase log levels. Use lowercase ones.

[MQ] In startBuildRawEvents2022.sh, various improvement + add Add selection with min nb of fired TOF RPC

- allow setting the minimum number of fired layers for TOF
- allow using trigger parameter sets as arguments, matching the one of the NH version
- always require the run ID as argument
- have time offsets matching those of the NH version

[mTOF,mBmon] In unpack macro and device, prepare support for different mTOF maps for C, Fe and Ur files

- Improve the string to system conversion for the parameters in CbmDeviceBuildDigiEvents
- Add support for the min number of fired layers parameter in CbmDeviceBuildDigiEvents and runBuildDigiEvents

- Add proper Bmon support to unpack + build digi events chain
- Add proper Much support to unpack + build digi events chain
- Add user parameter + flags to CbmDeviceUnpack to enable/disable the unpacking of each detector
- Add proper handling of disabled detectors in MQ transfer ib both CbmDeviceUnpack and CbmDeviceBuildDigiEvents
- Add parameter to set "MaxNb" type selection in CbmDeviceBuildDigiEvents
- Synchronize unpackers configuration in CbmDeviceUnpack with the one in the current `macro/run/run_unpack_tsa.C`
- Use fles::SubsystemIdentifier instead of hard coded values in CbmDeviceUnpack

- Add optional method to resort indicices to the CbmEvent class, as the indices for TRD1D and 2D are added in separate steps
- Replace the loop over the CbmEvent indices by a block copy between the first and last digi of each detector type, based
  on the assumption that we use a time-window based selection on a sorted array, therfore leading to a continuous block
  => this is known to potentially copy more digis in the TRD case due to the eventual =/= windows and offsets for 1D and 2D

- Make sure that Histo servers gets the right number of parts even if no histos/no canvases to configure or send
- Do not send STOP command after EOF in CbmMQTsSamplerRepReq
- Pre-book capacity in typical range for input vectors in DigiEventBuilder device