Transition to Modern CMake (Remaining CMakeList.txt files)
Gtest and GtestMain Target created which depend on GTEST target
Remaining files which haven't been changed in modern cmake.
MQ/monitor : Transition in Modern CMake
core/data/test: Transition to Modern CMake
reco/qa: Transition to Modern CMake
tutorial/TaskToAlgo: Transition to modern CMake
Merge request reports
Activity
Dear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
@osingh That would be a modern cmake replacement of !1005 (closed) right?
If yes I will close the other one with a message pointing to this one
@p.-a.loizeau I am just checking if it works. May be @f.uhlig can comment which one should be merge? I had just missed some files which need to change.
I put both MRs in draft mode such that they are not merged by accident. I have to do some checks before merging since I need to understand why the problem isn't seen with our CI tests.
@o.singh,
I put the installation of the library in !1008 (merged). Your MR combines the installation and some cleanup but only mention one of them in the commit message. Please create a proper commit message for the cleanup part after !1008 (merged) was merged.
added 7 commits
-
23d6a886...884e0cea - 4 commits from branch
computing:master
- 6a83a777 - Install target and Files
- d65e63f3 - Transition to Modern CMake
- 289d6697 - transition to modern cmake
Toggle commit list-
23d6a886...884e0cea - 4 commits from branch
added 5 commits
-
e522a474...884e0cea - 3 commits from branch
computing:master
- 2d99b039 - Transition to Modern CMake
- b4e83b4a - Merge branch 'cmake_remaining_files' of https://git.cbm.gsi.de/om/cbmroot into cmake_ana_dev
-
e522a474...884e0cea - 3 commits from branch
- Resolved by Omveer_Singh
- Resolved by Omveer_Singh