Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of NO_ROOT flag and algo log library to libraries in reco folder

[BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of both NO_ROOT flag and algo log lib to libraries in reco folder

• Build AlgoOffline library only if not in CBM_ONLINE_STANDALONE (aka not online container mode)
• Build [Ca/Kf]CoreOffline libs only if not in CBM_ONLINE_STANDALONE (aka not online container mode)
• Use AlgoOffline as dep for libs CbmSimDigitizationSteer CbmAtConverterSteer CbmRecoOfflineSteer

Redmine: Refs #3399

Extracted from !1874 (merged) and related to !1884 (merged)

Similar pings as in issue (in alphabetic order, not sure whom should cross-check this): @d.smith @fweig @f.uhlig @j.decuveland @v.friese

added BugFix Build System Framework Logging/printouts Online labels

marked this merge request as draft

added 3 commits

• 0b6dd2d2 - Revert back reco L1 to using only FairLogger
• 8614fbd6 - Use FairLogger instead of cout in CbmKFPartEfficiencies
• d234d18c - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

Compilation crash was due to lacking the last 2 commits of !1874 (merged) which are required here due to some implicit includes being gone

Hopefully the other MR will be merged first

mentioned in merge request !1874 (merged)

Dear @d.smith, @fweig, @i.selyuzhenkov, @se.gorbunov, @s.zharko, @ma.beyer, @v.friese, @f.uhlig, @p.-a.loizeau,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 12 commits

• d234d18c...19971d11 - 9 commits from branch computing:master
• a97e730a - Revert back reco L1 to using only FairLogger
• d079d46f - Use FairLogger instead of cout in CbmKFPartEfficiencies
• 3512d37c - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

added 4 commits

• a90d0dcc - 1 commit from branch computing:master
• 149b309c - Revert back reco L1 to using only FairLogger
• 80121a81 - Use FairLogger instead of cout in CbmKFPartEfficiencies
• a2900fd1 - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

added 14 commits

• a2900fd1...6390397e - 11 commits from branch computing:master
• 1ba527f6 - Revert back reco L1 to using only FairLogger
• 165cd175 - Use FairLogger instead of cout in CbmKFPartEfficiencies
• 91491788 - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

added 7 commits

• 91491788...b625f7f9 - 4 commits from branch computing:master
• 0cf882c4 - Revert back reco L1 to using only FairLogger
• afcd61d3 - Use FairLogger instead of cout in CbmKFPartEfficiencies
• c1afdfba - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

added 17 commits

• c1afdfba...34ff68c8 - 16 commits from branch computing:master
• 0d008bd2 - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

added 8 commits

• 0d008bd2...94040dab - 7 commits from branch computing:master
• a33208db - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

assigned to @f.uhlig

added 3 commits

• a33208db...584a3864 - 2 commits from branch computing:master
• b375b9d0 - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

@p.-a.loizeau,

the MR looks okay for me but it should be cross-checked by @fweig.

added 29 commits

• b375b9d0...429452b9 - 28 commits from branch computing:master
• 5e6ee89d - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

added 1 commit

• 9993b154 - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...

Compare with previous version

added 1 commit

• 53ee268c - Try to fix missing dependency in CbmAlgoOffline on Linux

Compare with previous version

added 1 commit

• ac084c92 - Fix missing dependency of CbmAlgoOffline in Linux CI builds (local builds OK without)

Compare with previous version

added 1 commit

• 587ecc63 - Fix missing dependency of CbmAlgoOffline in Linux CI builds (local builds OK without)

Compare with previous version

added 1 commit

• d5803e7a - Fix missing dependency of CbmAlgoOffline in Linux CI builds (local builds OK without)

Compare with previous version

@f.uhlig Would you happen to have a clue as to why I have to remove a static on a private member variable as in my "fix commit" to avoid these CI/Dart build errors?

After copying the Dart.cfg files from a failed CI build on run4, I could reproduce the error by hand with a "Dart" build, but the local "cmake" builds from the same source folder were OK, even when trying to force the MergeRequest model.
The only obvious difference I could find in the build folder config files (cmake and auto-generated make files) where a few occurrences of NIGHTLY (failing Dart local build) being replaced by FullWarning (working "cmake" local build).

Another strange thing is the original libAlgo library is properly linked while my new libAlgoOffline is not, even though I copied all settings from one to the other apart from the logger libraries change in the CMakefile.

So I am a bit confused as I cannot find anything wrong with the original code from the C++ side. Maybe something with how the call to this variable is processed by the two different logger libraries at l.286 of ReadoutConfig.cxx?

added 13 commits

• d5803e7a...94fee10f - 11 commits from branch computing:master
• c5b60700 - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...
• a9fb94b7 - Fix missing dependency of CbmAlgoOffline in Linux CI builds (local builds OK without)

Compare with previous version

added 7 commits

• a9fb94b7...fa1f22d3 - 5 commits from branch computing:master
• a1e834f9 - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...
• 23479f14 - Fix missing dependency of CbmAlgoOffline in Linux CI builds (local builds OK without)

Compare with previous version

added 4 commits

• 23479f14...7d7b1a1d - 2 commits from branch computing:master
• eb600eb4 - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...
• 5952ed9f - Fix missing dependency of CbmAlgoOffline in Linux CI builds (local builds OK without)

Compare with previous version

@p.-a.loizeau,

for me the MR looks okay, as I also stated 3 weeks ago. Since there is no response from @fweig I would propose to merge it. If you agree please remove the Draft mode.

approved this merge request

Then I will remove/comment the debug pre-processor printout and remove the draft state once I push it (first I need to remember where these printout were added )

added 2 commits

• 7095bcdc - [BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of...
• 712d0b65 - Fix missing dependency of CbmAlgoOffline in Linux CI builds (local builds OK without)

Compare with previous version

marked this merge request as ready

Removed draft state after commenting out the pre-processor warnings which allow to trace which log library is loaded where when compiling.

I chose to keep them available, as they will be necessary if at some point in the future somebody choose to try to address the root problem instead of going around it as I did here.

changed title from Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of NO_ROOT flag to libraries in reco folder to Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of NO_ROOT flag and algo log library to libraries in reco folder

changed the description

merged