Applied TRD hotfix to online code.
Applied changes from !1752 (merged) to online code.
@apuntke could you please check whether this captures the essence of your hot fix? Please only look at the latest commit, as this is based off of !1759 (merged), which touches lots of files.
Row merging is not covered, as the online code currently does not support it.
Assigned to @a.bercuci. Reviewer should be @apuntke but GitLab doesn't allow it.
Perhaps of interest to @p.-a.loizeau
Merge request reports
Activity
requested review from @a.bercuci
assigned to @a.bercuci
added 5 commits
-
455f75c6...ec494a7b - 3 commits from branch
computing:master - 658a9395 - - Added online capable TRD hitfinders (1D and 2D) in cbm::algo.
- 8d790aba - Applied hotfix from MR 1752 to online TRD code.
-
455f75c6...ec494a7b - 3 commits from branch
Hi Dominik, thanks for including the hotfix into your new clusterizer algorithm. When looking at the code it looks good for me and should work as expected. The case which was fixed with the hotfix is illustrated in this picture:
Here you see a cluster consisting of two selftriggered digis on channels 3023 and 3024 of one of the type 5 modules which were recently installed in mCBM. This cluster should not be built because these digis are on different padrows. The version of the old clusterizer without the hotfix clusters these two digis while the new version doesn't. You could feed those 2 digis into your clusterizer and see if it correctly creates 2 different clusters out of them. I recommend to try both orders (ch3023 first, ch3024 second, and vice versa).
Dear @d.smith, @fweig, @a.bercuci, @p.kaehler, @f.uhlig, @p.-a.loizeau, @v.friese,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
I will try to update the tests from MR1744 such that they work with your new version to check this MR.
Hi @d.smith , It is great that you have finished this major job. I will be in GSI starting with Monday 22nd and we will be able to have a hands on experience on the code. Until than I will not be able do allocate time to it.
@a.bercuci @apuntke Against my initial statement, I have decided to absorb this MR into !1759 (merged). Please continue discussions there. Closing.
