TRD Clusterizer Hotfix
This MR fixes the problem in the TRD clusterizer that occurs when two selftriggered digis are on neighbored addresschannels but inbetween is a change in the padrow. Previously these digis were added to the same cluster, with this fix this should not happen anymore.
Also the IsClusterComplete function is hardened against incorrect cluster sizes reported by CbmTrdCluster::GetNCols() and CbmTrdCluster::GetNRows(), which were reported for the incorrectly built clusters described above and led to crashes in reconstruction of mCBM2024 data.
Merge request reports
Activity
Dear @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
Thanks for setting up, addressing (avoiding) the crashing situation which, i.a, the TOF team was facing. Therefore, if @p.-a.loizeau and @f.uhlig would agree, having it merged soon would be desirable.
added BugFix label
requested review from @a.bercuci
assigned to @p.-a.loizeau
Ping @d.smith as it may fit some of the discussions in !1605 (closed) and !1747 (closed) (I confess I did not follow all the details there
)Edit: was linking the wrong draft MR, sorry
Edited by Pierre-Alain Loizeauadded Reconstruction label
added mCBM label
- Resolved by Axel Puntke
If this is an urgent fix then please proceed with the merge. We can incorporate the changes into the algo version later.
added 7 commits
-
96171b9a...392f2621 - 5 commits from branch
computing:master
- e635edce - TRD Clusterizer Hotfix
- 86f1ea83 - Apply clang-format
-
96171b9a...392f2621 - 5 commits from branch
enabled an automatic merge when the pipeline for 3cd3ed26 succeeds
mentioned in merge request !1733 (merged)
mentioned in merge request !1759 (merged)
mentioned in merge request !1761 (closed)