algo: Add skeleton for cbmreco app.
Adds the cbmreco
binary. This is just a dummy for the moment that doens't do anything. I'll add features from my fork in upcoming MRs to reproduce the results i have there.
There's a lot of overlap with the existing cbmreco_fairrun
binary. Once i have reproduced the state from my fork, i'll try to merge those two.
Merge request reports
Activity
assigned to @fweig
Dear @f.uhlig, @v.friese, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
mentioned in merge request !1161 (merged)
requested review from @j.decuveland
- Resolved by Felix Weiglhofer
@j.decuveland, I've renamed the
input-file
flag tofles-locator
for consistency with the naming infles::TimesliceAutoSource
.Edited by Felix Weiglhofer
- Resolved by Jan de Cuveland
First of all: I have no objections to this MR.
I do have a few questions and comments:
- The
Options
struct can hardly be reviewed without more context. Forstd::filesystem::path InputFile() const { return fInputFile; }
, could you have a look at TimesliceAutoSource.hpp? I think we could better use something like:
std::string TimesliceSourceLocator std::string InputLocator
- As mentioned earlier, the FairLogger library has two issues that may make it less than ideal for the online application: First, it does not easily support syslog, and second, it limits console output performance by requiring a sync after every message.
If we don't want to introduce an additional dependency, we could use the minimalistic library (small wrapper around boost_log) that is included in cbmroot through Flesnet: logging (ascbmreco_fairrun
already does). It can easily be replaced by a more evolved solution in the future.
- The
added 7 commits
-
0c1ed027...64321a41 - 5 commits from branch
computing:master
- ce9c360b - algo: Add config micro-library to read YAML files and map to C++ classes.
- b457fa95 - algo: Add skeleton for cbmreco app.
-
0c1ed027...64321a41 - 5 commits from branch
mentioned in merge request !1164 (merged)
added 8 commits
-
b457fa95...59b6cd65 - 6 commits from branch
computing:master
- b9d061ac - algo: Add config micro-library to read YAML files and map to C++ classes.
- 76c414ed - algo: Add skeleton for cbmreco app.
-
b457fa95...59b6cd65 - 6 commits from branch
enabled an automatic merge when the pipeline for 76c414ed succeeds
mentioned in merge request !1152 (closed)