Omveer Singh authored 2 years ago and Omveer_Singh committed 2 years ago

MQ/monitor/CMakeLists.txt: Boost added as dependency
algo/data/CMakeLists.txt: modified in Modern CMake
algo/test/CMakeLists: modified in Modern CMake
core/data/test/global/CMakeLists.txt: Unnecessary dependencies removed and added required dependencies
core/data/test/psd/CMakeLists.txt: Unnecessary dependencies removed
core/detectors/trd/CMakeLists.txt: TMVA dependency change to ROOT::TMVA

Omveer Singh authored 2 years ago and Omveer_Singh committed 2 years ago

Gtest and GtestMain Target created which depend on GTEST target

Remaining files which haven't been changed in modern cmake.
 MQ/monitor : Transition in Modern CMake
 core/data/test: Transition to Modern CMake
 reco/qa: Transition to Modern CMake
 tutorial/TaskToAlgo: Transition to modern CMake

unnecessary commands removed which oprated a directory level.
like include_directories() link_directories()
Now operating on the target directory using target_include_directories()
target_link_libraries() commands.
generating library target using generate_cbm_library() macro provided by us.

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

With commit 892f01a1 from 23.03.22 the layout
of the data class CbmTsEventHeader was changed by adding a new data member. At
that time it was forgotten to also increase the version number. This commit
increases the version number and corrects the issue.

Jan de Cuveland authored 2 years ago and Administrator committed 2 years ago

- fles_ipc -> external::fles_ipc
- fles_logging -> external::fles_logging
- IPC_INCLUDE_DIRECTORY -> FLES_IPC_INCLUDE_DIRECTORY

Fix deprecation warnings about upercase log levels. Use lowercase ones.

- Add optional method to resort indicices to the CbmEvent class, as the indices for TRD1D and 2D are added in separate steps
- Replace the loop over the CbmEvent indices by a block copy between the first and last digi of each detector type, based
  on the assumption that we use a time-window based selection on a sorted array, therfore leading to a continuous block
  => this is known to potentially copy more digis in the TRD case due to the eventual =/= windows and offsets for 1D and 2D

Layers can be stations or sensors depending on the sub-system and implementation

- Add maskers for Strip address and Rpc address in CbmTofAddress
- Update comments and description of bit map in CbmTofAddress
- Add parameter + setter + base logic for selection on minimum nb of fired layers in CbmAlgoBuildRawEvents
- Add implementation of count + cut for the TOF case in CbmAlgoBuildRawEvents

Vikas Singhal authored 3 years ago and Pierre-Alain Loizeau committed 2 years ago

- Add MUCH unpacker algo/config and monitoring classes in the current scheme
- Add new unpacking parameter class
* Separate the parameter files for the 2022 monitor and the 2022 unpacking
- Add MUCH in RecoUnpack
- Add MUCH in run_unpack_tsa and run_unpack_online macros

- Update Mcbm2018TofPar to map the 2022 BMon diamond
- Update Mcbm2018TofPar to map the new TOF modules for the 2022 iron beams (run 2100 onward)
- Add a BmonUnpackConfig class setting up the TOF unpacker to BMon mode
- Add a TofUnpackMonitor class providing monitoring plots for TOF and BMon unpacking
- Integrate this one in the TOF unpack algo
- Fix incomplete switching for the 2021 epoch hack in the TOF unpack Algo
- Add Bmon in the sterring RecoUnpack task
- Add a monitoring only mode to the RecoUnpack task were data is neither time sorted nor written to disk
- Add BMon in the unpacking macros
- Add the TOF monitor(s) to the unpacking macros
- Add BMon only unpacking macros for fast beam monitoring (especially for beam tuning)
- Add parameter files for TOF and BMon in the 2022 campaign

Volker Friese authored 3 years ago and Jan de Cuveland committed 3 years ago

Modifications following the suggestions of P.-A. Loizeau and J. de Cuveland (see #2268). Refs #2268.

Use std::string instead of TString to format log output.

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Split the InitUnpacker method of the UnpackConfig template into
  - InitOutput
  - RegisterOutput (Framework bound, to be replaced by method in Task class CbmRecoUnpack)
  - SetAlgo
  - initParContainer, moved to the Task Class CbmRecoUnpack
  - InitAlgo
- Move to the template version of these methods all blocks common to all derived config classes
- Whenever necessary, overload these methods in the derived config classes (including the common parts, no base method call)
- Bump Config classes version number
- Adapt the Sts Unpack algo classes to initialize the monitor classes
- Adapt the CbmRecoUnpack
- Adapt the CbmUnpackDevice to use the standard Unpack Config classes (compiles with full functionality but untested)

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add all data classes needed by libAlgo to libOnlineData.
Add all other referenced classses to libOnlineData.
Remove ROOT dependencies from all these classes.

Link libAlgo against libOnlineData.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- Move implementation of CbmMuchAddress::SetElementId to cpp file
- Move Logger include from header to cpp
- Add missing Logger include to CbmMuchSignal cxx file
- Add missing Logger include to CbmAnaDimuonAnalysis cxx file (needed only for FS/FR jun19-v18.2)

Induced by inclusion in DigiData of the other detectors on top of STS (needed only for FS/FR higher than FS/FR jun19-v18.2)