Add Trd2d to the data reconstruction

The current MR is a follow up of the !634 (closed) after solving the issue with different branch names for the TrdDigi produced by the SPADIC and FASP respectively.

Depends on CbmSoft/cbmroot_parameter!84 (merged)

changed title from WIP : Add Trd2d to data the reconstruction to WIP : Add Trd2d to the data reconstruction

added 14 commits

• 325f80d0...d5e086e7 - 4 commits from branch computing:master
• b275f90b - fix Trd2d FEE to GEO mapping
• 7216a40a - update for Fasp FEE
• 64e193fc - use unified TrdDigi class for both SPADIC and FASP FEE systems
• d2f3acd8 - fix codding convention
• 77f5ac26 - renamed ModuleRecT to ModuleRec2D
• c79d41c3 - modify interface.
• d3502752 - rename ModuleRecT to ModuleRec2D and fix hit counter for EbyE and TB
• 7fb9f901 - add support for mixed read-out on different chamber geometries
• 1e62a521 - fix naming in various print-outs
• c977261b - remove different branch name for Fasp Digi

Compare with previous version

added 1 commit

• 63939e20 - link for the new ASIC par files needed by the Trd2d

Compare with previous version

mentioned in merge request CbmSoft/cbmroot_parameter!81 (merged)

changed the description

added 1 commit

• b1382eaa - add FASP mapping on GEO for mCBM 21, explicit printing of the mapping,

Compare with previous version

added 1 commit

• f5b9a944 - fix format

Compare with previous version

added 19 commits

• f5b9a944...24bc7a4b - 5 commits from branch computing:master
• e584e5b2 - fix Trd2d FEE to GEO mapping
• 6d8e1141 - update for Fasp FEE
• 6901f2c2 - use unified TrdDigi class for both SPADIC and FASP FEE systems
• b62ef38a - fix codding convention
• d0d4c46a - renamed ModuleRecT to ModuleRec2D
• 88d181fe - modify interface.
• 1a77d8df - rename ModuleRecT to ModuleRec2D and fix hit counter for EbyE and TB
• 49f89660 - add support for mixed read-out on different chamber geometries
• 7d0852b6 - fix naming in various print-outs
• 79c81d33 - remove different branch name for Fasp Digi
• 7d38f99f - link for the new ASIC par files needed by the Trd2d
• 37414c3c - add FASP mapping on GEO for mCBM 21, explicit printing of the mapping,
• 4ccf84ca - fix format
• 6fe5a649 - add explanation to the LOG(fatal) as requested in https://redmine.cbm.gsi.de/issues/2373

Compare with previous version

mentioned in merge request CbmSoft/cbmroot_parameter!82 (merged)

@a.bercuci @apuntke What is the status here, is the MR to be declared ready/approved from TRD side? I am also asking, as another parameter update addressing the TRD-1D params is to be pushed soon, and maybe should be done "one after the next".

The MR for the new v21c and v21d TRD parameters is already merged into the parameter repository, see this commit: CbmSoft/cbmroot_parameter@2204b99c But this files do not yet contain the updates on the FASP parameters. They must be updated then too.

mentioned in merge request !730 (merged)

mentioned in merge request CbmSoft/cbmroot_parameter!83 (merged)

mentioned in merge request !719 (merged)

added 15 commits

• 1709cd11 - 1 commit from branch computing:master
• 3a57534e - fix Trd2d FEE to GEO mapping
• 508bb940 - update for Fasp FEE
• 3b7869c9 - use unified TrdDigi class for both SPADIC and FASP FEE systems
• c896aa59 - fix codding convention
• ddf73f5c - renamed ModuleRecT to ModuleRec2D
• bae68ca0 - modify interface.
• b9f71480 - rename ModuleRecT to ModuleRec2D and fix hit counter for EbyE and TB
• 42199367 - add support for mixed read-out on different chamber geometries
• 9949c94f - fix naming in various print-outs
• 4d986454 - remove different branch name for Fasp Digi
• 9200ad6e - link for the new ASIC par files needed by the Trd2d
• c66db4f9 - add FASP mapping on GEO for mCBM 21, explicit printing of the mapping,
• 03451d3c - fix format
• 40888441 - add explanation to the LOG(fatal) as requested in https://redmine.cbm.gsi.de/issues/2373

Compare with previous version

Hi @f.uhlig The MR does not pass all tests because the build on MAC has the following error:

In file included from /Users/fairroot/builds/a.bercuci/cbmroot/reco/detectors/trd/unpack/CbmTrdUnpackAlgoFasp2D.cxx:6:
In file included from /Users/fairroot/builds/a.bercuci/cbmroot/reco/detectors/trd/unpack/CbmTrdUnpackAlgoFasp2D.h:25:
In file included from /Users/fairroot/builds/a.bercuci/cbmroot/reco/base/CbmRecoUnpackAlgo.tmpl:24:
In file included from /Users/fairroot/builds/a.bercuci/cbmroot/external/ipc/ipc/lib/fles_ipc/MicrosliceDescriptor.hpp:9:

see e.g. : https://cdash.gsi.de/viewBuildError.php?buildid=318080 It is obviously triggered by this code but it is not related to it; rather to the compiler settings on this platform. Can you please help me solve it ?!

Best

Alex

added 17 commits

• 40888441...a2927267 - 2 commits from branch computing:master
• dd3c1702 - fix Trd2d FEE to GEO mapping
• 49a228e0 - update for Fasp FEE
• a0dc1446 - use unified TrdDigi class for both SPADIC and FASP FEE systems
• 4f2b3c73 - fix codding convention
• 7b087787 - renamed ModuleRecT to ModuleRec2D
• 6487dbd8 - modify interface.
• 4b7116f2 - rename ModuleRecT to ModuleRec2D and fix hit counter for EbyE and TB
• 85ef2d05 - add support for mixed read-out on different chamber geometries
• 12c27490 - fix naming in various print-outs
• aa924c0f - remove different branch name for Fasp Digi
• a62b293c - link for the new ASIC par files needed by the Trd2d
• 1d2477fd - add FASP mapping on GEO for mCBM 21, explicit printing of the mapping,
• cc7db73f - fix format
• 3fa5d3a9 - add explanation to the LOG(fatal) as requested in https://redmine.cbm.gsi.de/issues/2373
• 4047df95 - fix compilation on MacOS

Compare with previous version

changed title from WIP : Add Trd2d to the data reconstruction to Add Trd2d to the data reconstruction

approved this merge request

@p.kaehler,

who should review the code from the TRD group? I had a quick look at it from the framework and C++ perspective but I can't judge the algorithmic part.

added 1 commit

• c1d9ac4b - code formating asked during revision of the code (F. Uhlig)

Compare with previous version

mentioned in commit a.bercuci/cbmroot@ab69fa64

added 1 commit

• ab69fa64 - fix codding format (!728 (comment 19372))

Compare with previous version

mentioned in commit a.bercuci/cbmroot_parameter@c5050718

mentioned in merge request CbmSoft/cbmroot_parameter!84 (merged)

changed the description

Dear @a.bercuci, @p.kaehler, @f.uhlig, @p.-a.loizeau,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

mentioned in commit a.bercuci/cbmroot@950f2d43

added 18 commits

• 3d98e989 - 1 commit from branch computing:master
• c19c7a79 - fix Trd2d FEE to GEO mapping
• ad2cc26e - update for Fasp FEE
• e2dac1c4 - use unified TrdDigi class for both SPADIC and FASP FEE systems
• 8bd388a0 - fix codding convention
• fea2f452 - renamed ModuleRecT to ModuleRec2D
• 9dc2dfcb - modify interface.
• be1e4494 - rename ModuleRecT to ModuleRec2D and fix hit counter for EbyE and TB
• 4a3df26b - add support for mixed read-out on different chamber geometries
• 40131518 - fix naming in various print-outs
• 8194390d - remove different branch name for Fasp Digi
• 8e689239 - link for the new ASIC par files needed by the Trd2d
• e19efebb - add FASP mapping on GEO for mCBM 21, explicit printing of the mapping,
• c0ce6693 - fix format
• 91381b93 - add explanation to the LOG(fatal) as requested in https://redmine.cbm.gsi.de/issues/2373
• 60ace8c5 - fix compilation on MacOS
• 4d98d563 - code formating asked during revision of the code (F. Uhlig)
• 950f2d43 - fix codding format (!728 (comment 19372))

Compare with previous version

mentioned in commit a.bercuci/cbmroot_parameter@27d4d74c

resolved all threads

mentioned in merge request !742 (merged)

mentioned in commit a.bercuci/cbmroot@bd33f3dc

added 19 commits

• 950f2d43...04392d94 - 2 commits from branch computing:master
• 5e5fcebb - fix Trd2d FEE to GEO mapping
• b3eafe67 - update for Fasp FEE
• e6d1294e - use unified TrdDigi class for both SPADIC and FASP FEE systems
• 0ac98238 - fix codding convention
• 3c9137d5 - renamed ModuleRecT to ModuleRec2D
• 22d7b90a - modify interface.
• 0d93390f - rename ModuleRecT to ModuleRec2D and fix hit counter for EbyE and TB
• ace5d5b3 - add support for mixed read-out on different chamber geometries
• 9e046b3d - fix naming in various print-outs
• ae839d0f - remove different branch name for Fasp Digi
• 98c93adb - link for the new ASIC par files needed by the Trd2d
• 6d0150ad - add FASP mapping on GEO for mCBM 21, explicit printing of the mapping,
• 59e26f90 - fix format
• 62732aeb - add explanation to the LOG(fatal) as requested in https://redmine.cbm.gsi.de/issues/2373
• af75f0d3 - fix compilation on MacOS
• 3c6e56c1 - code formating asked during revision of the code (F. Uhlig)
• bd33f3dc - fix codding format (!728 (comment 19372))

Compare with previous version

Which changes in the geometry, parameter and input repositories are connected to this MR?

Sorry but I completely lost track.

resolved all threads

enabled an automatic merge when the pipeline for bd33f3dc succeeds

assigned to @f.uhlig

approved this merge request

resolved all threads

merged