Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Remove wrong license header drom several files which came in by using a
template. The code was developed by the respective persons, the license header
came in by using a skeleton.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Exclude ParMQServer classes from test. Code was copied from FairRoot which
has its ownclicense header.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add the external directories to the list of directories which shouln't be
tested.
Only test a file that exists. This solves a problem when files are removed
from the repository.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The code was copied at some time from an external project into the lx
directory. Since it fails the license header check the code was moved
to the externals directory. Also a second copy of the headers were deleted.

Eoin Clerkin authored 3 years ago and Florian Uhlig committed 3 years ago

Allows knowledgable user to swith between the previous official default geometry configurations,
the current recommended defaults and specific test environments to be investigated for future
releases.

Remove wrong license header drom several files which came in by using a
template. The code was developed by the respective persons, the license header
came in by using a skeleton.

Rearranged tests in macro/run/CMakeLists.txt. Changed naming convention such that FIXTURES_SETUP is named after the current test and FIXTURES_REQUIRED contains names of required tests.

All files were developed by Nikolay Karpushkin who now is listed correctly.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

Bug 2: In both Legacy and current unpackers, a signed integer was used at some point to store/return the raw timestamp in clock cycles.
While the last bit would probably never be reached in standard usage, it could lead to negative values and crazy results during the
conversion through double (full precision time in ns) and back to unsigned integer (ns precision time) for data coming from badly
synchronized setups

Bug 3: In the current unpacker, the subtraction of the Timeslice start time from the TS_MSB value was not protected against the case of
badly synchronized data where the TS_MSb does not match the Timeslice index. It now triggers a Fatal as these data are not recoverable
with this unpacker.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

Bug 1: Size was too small which led to some digis with TS_MSB above 65555 escaping the duplicates filter.
No effect on the digi themselves (time is computed from the original 64b/32b value).

In the legacy case we can stay with 32b (instead of the original 64b or the old 16b) as the field in the
raw message is 29b, while in the current version we need 64b to account for potential TS_MSB cycles and
large Timeslice start offset.

Alexandru Bercuci authored 3 years ago and Florian Uhlig committed 3 years ago

protect against missing par files
update steering macro for the new TRD-2D interface
incorporate parameter calibration into the FASP read-out data
protect the code for the case of par un-consistency (found e.g. for TRD-2Dh)
add user interface to the Asic param set
rename modules in the TRD setup
extend the TRD module type index above one digit
adding class definition to allow SPADIC info generation during unpacking

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The wrong license headers currently block the merging of !470.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- Add vector constructor to CbmSourceTsArchive
- Call string constructor of FLES IPC TimesliceAutoSource if vector of size 1
- Make vector input default in run_unpack macro
- Add alternative call with single string to run_unpack_macro to keep legacy interface available

Exclude code from directory analysis/PWGDIL/dielectron/papaframework.
The code of the papa framework currently has its own license header since the
code was original developed for the ALICE collaboration before the original
author copied the code also to CbmRoot.

Dominik Smith authored 3 years ago and Florian Uhlig committed 3 years ago

Moved CbmStsDigitizeQa, CbmStsDigitizeQaReport and CbmStsFindTracksQa to qa subfolders. Updated CMakeLists.txt accordingly.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add / as allowed character in the regex which checks the copyright statement.
This is needed since we have cases with two institutes and two cities in the
copyright statement which are separated by a /.