Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

The target is not available in newer FairMQ versions.

Omveer Singh authored 2 years ago and Omveer_Singh committed 2 years ago

MQ/monitor/CMakeLists.txt: Boost added as dependency
algo/data/CMakeLists.txt: modified in Modern CMake
algo/test/CMakeLists: modified in Modern CMake
core/data/test/global/CMakeLists.txt: Unnecessary dependencies removed and added required dependencies
core/data/test/psd/CMakeLists.txt: Unnecessary dependencies removed
core/detectors/trd/CMakeLists.txt: TMVA dependency change to ROOT::TMVA

Omveer Singh authored 2 years ago and Omveer_Singh committed 2 years ago

Gtest and GtestMain Target created which depend on GTEST target

Remaining files which haven't been changed in modern cmake.
 MQ/monitor : Transition in Modern CMake
 core/data/test: Transition to Modern CMake
 reco/qa: Transition to Modern CMake
 tutorial/TaskToAlgo: Transition to modern CMake

Jan de Cuveland authored 2 years ago and Administrator committed 2 years ago

- fles_ipc -> external::fles_ipc
- fles_logging -> external::fles_logging
- IPC_INCLUDE_DIRECTORY -> FLES_IPC_INCLUDE_DIRECTORY

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

The templated functions Deserialize and Serialize of the FairMQ Device are
marked deprecated. These templates acctually only forward the call to the
BoostSerializer and RootSerializer classes which are part of FairRoot.
Call these classes directly to remove deprectaion warnings.

Use @VMCWORKDIR@ instaed which is exchanged by the acctual value while running
CMake. In case of $VMCWORKDIR/build uses @CMAKE_BINARY_DIR@.

Create MQ startup scripts to be installed already at the configuration stage
and store the in the build tree. The difference between the scripts used in
the build tree and the scripts finally installed are the hardcoded directory
information inside. In the scripts to be used inside the build directory this
links to the source and the build directories whereas it links to the
installation directory in case of the scripts which are installed.
Copy the scripts during installation to the correct directory.
Install the MQ executables in the same directory structure as in the build
directory.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Remove wrong license header drom several files which came in by using a
template. The code was developed by the respective persons, the license header
came in by using a skeleton.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Comment unused variables and data members.
Fix printf formating issue which is different between macosx and Linux.

A static const class member in a cout statement results in an undefined symbol
when linking an executable using the class.
The solution is to do a static cast of the variable in the cout statement.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

It was advised by the FariMQ expert to switch from a push-pull approach to a Rep-Req one.
This should improve the balance of TS delivery when they have non uniform size/processing time
and reduce the buffering in the Sample
- Add new sampler class CbmMQTsSamplerRepReq using the reply model
- Add example of a consummer device using the request model
- Add new monitor classes for T0 and TOF using the request model

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- In CbmMqHistoServer, add a new method processing a multi-part message to combine Histo config, Canvas config and histo data
- Attach this new method to the histo data input channel
- Convert the T0 MQ monitor to this single channel usage
- Convert the Tof MQ monitor to this single channel usage

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- In both, add InitHistograms method
- Call InitContainers and InitHistograms in Run and only on first message

Unify user names in the license header authors list.
Remove duplicate users in the authors list.
Cleanupo of some other inor issues.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

- Add threshold for non pulser digis in both algo, Task and device
- Make interval for spill threshold checks configurable in both algo, Task and device
- Spill detection only when both threshold passed
- Add Monitor macro for mCBM 2021 using this functionality

Pierre-Alain Loizeau authored 4 years ago and Volker Friese committed 4 years ago

Fixes in mCBM 2020 Algos and MQ examples:
- Remove JSROOT commands fore reset/save histos in MQ histos server and devices, as not working (need cling context!).
- Add/extend support for T0 channels remapping + related plots.
- Fix TOF pulser algo (logic was broken before and chain resetting the output plots).
Add macro folder + MQ monitor scripts for TOF and T0.

Add support for C++17
Check for c++ version c++11 or above (11, 14 or 17). With this change it
becomes possible to compile CbmRoot with C++17.

Add missing library.
The FairMQ state machine is now in an extra library which has to be added
for linking when using FairSoft nov20. Test if the library exist and create
the list of dependencies accordingly.

Add missing include directory.
VMC is not any longer included in ROOT but a standealone package, so the
include directory has to be added such that the header files are found.

Add gtest as an optional external package.
With the latest version of FairSoft googletest was removed due to a
recommendation of the gtest developers. Since gtest is no longer part of
FairSoft we have to provide an own version which is compiled as external
project.

Add proper dependency to external gtest project
This dependency is needed to compile the test only if the gtest library is
already available.

Fix compilation error with FairRoot v18.4.2 on macosx
In FairRoot v18.4.2 some linker settings were removed from the CMake setup.
This breaks the compilation of CbmRoot. Put back the needed seetings for the
linker on macosx in our build system.

Fix NicaFemto installation

Apply code formatting to all source/header files and root macros.

This version is an exact copy of the last revision of the trunk branch
of the old SVN repository of CbmRoor at
https://subversion.gsi.de/cbmsoft/cbmroot/trunk
The old SVN repository will still be available for read access.