Administrator authored 1 week ago and Pierre-Alain Loizeau committed 1 week ago

The most non ASCII characters were used in comments but some were also used
for screen output. The most common non ASCII character was µ which was
exchanged by mu or micro.

Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Incorporates the BMON into CBMROOT, allowing simulations with T0 and
Halo detectors.

The target is not available in newer FairMQ versions.

(CbmTrdParModAsic) and the proper set related. Add also CROB id to the
param file

Dominik Smith authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and CbmTaskBuildRawEvents. Dropped support for T0 digis in TOF stream.

Use the same target names as provided by FairRoot with version v18.8.

Add the new target FairRoot::Online which is a new library conatining the
online related code which was previously part of the Base library.
In case of older FairRoot versions the target is only an alias for the target
FairRoot::Base such that the same dependencies already work with FairRoot
v18.6 which is our current default version.

Add the new target FairRoot::Online in all CMakeLists.txt where it is needed.

The FindFairRoot macro is also used when compiling NicaFemto. Since there is a
problem with the target definitions in NicaFemto the targets are not defined
when compiling NicaFemto.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

With the upcoming FairRoot release the function FillEventHeader of the
FairRootManager is deprecated, so use the function from FairSource directly.
Fixes #2644.

Omveer Singh authored 2 years ago and Omveer_Singh committed 2 years ago

MQ/monitor/CMakeLists.txt: Boost added as dependency
algo/data/CMakeLists.txt: modified in Modern CMake
algo/test/CMakeLists: modified in Modern CMake
core/data/test/global/CMakeLists.txt: Unnecessary dependencies removed and added required dependencies
core/data/test/psd/CMakeLists.txt: Unnecessary dependencies removed
core/detectors/trd/CMakeLists.txt: TMVA dependency change to ROOT::TMVA

Omveer Singh authored 2 years ago and Omveer_Singh committed 2 years ago

Gtest and GtestMain Target created which depend on GTEST target

Remaining files which haven't been changed in modern cmake.
 MQ/monitor : Transition in Modern CMake
 core/data/test: Transition to Modern CMake
 reco/qa: Transition to Modern CMake
 tutorial/TaskToAlgo: Transition to modern CMake

CMakeList.txt files are modified according to modern CMake.
generate_cbm_executable() macro is used to make executable.
Imported targets of each package are used as dependencies.

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

Linking the MQ TSA  binaries on Debian11 need an additional boost library as
well as a reordering of the link libraries.

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

=> needed to collect histo and canvases from multiple instances of the devices (e.g. multiple nodes) in a single histo server
=> Same cannot easily be in processing classes like Unpack and BuildEvent as both name and folder need to be changed to avoid collisions

    - Fix to the performance plots of the DigiEventSink by changing the logic to Profile or new counts addition
    - Add option for DigiEvent I/O between builders and Sink

- Evolution of the full TS buffer size as function of device runtime
- Evolution of the missed TS buffer size as function of device runtime
- Evolution of the Processed full TS count as function of device runtime
- Evolution of the Processed missing TS count as function of device runtime
- Evolution of the Total processed TS count as function of device runtime
- Evolution of the Processed events count as function of device runtime

[MQ] in DigiEventSink, add flag to control Missing TS empty writing if consecutive check is ON, false by default

- The check for consecutive TS indices was still called when receiving Missing TS Data messages even if the bypass flag was set
  => Surround the call with proper if condition
- The range when taking the digis data out of the unpacked timeslice to the DigiEvent was missing the last digi for all detectors
  => Increment the stop iterator to make sure it is included
- In rare case, the device can be pulled down before the Init method is called/finished, which led to a segfault
  => add an InitDone flag + use it to control delete operations in the destructor