Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

With the latest change not all libraries were found any longer such
that not all libraries were tested.
The outcome of the test was such not reliable.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The script contained two problems. The first one was a typo in the shebang.
The second problem was in the grep command. If the full path includes by
chance the string "so" or "dylib" all files of the directory were found
accidentally. Requiring "so" or "dylib" to be at the end of the line fixes
the error.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Exclude ParMQServer classes from test. Code was copied from FairRoot which
has its ownclicense header.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add the external directories to the list of directories which shouln't be
tested.
Only test a file that exists. This solves a problem when files are removed
from the repository.

Exclude code from directory analysis/PWGDIL/dielectron/papaframework.
The code of the papa framework currently has its own license header since the
code was original developed for the ALICE collaboration before the original
author copied the code also to CbmRoot.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add / as allowed character in the regex which checks the copyright statement.
This is needed since we have cases with two institutes and two cities in the
copyright statement which are separated by a /.

Corrects a variable typo which leads to some false positives

Allows passthrough of all files before trigger error code, to allow to see all files which don't obey header format.

Allows checking of individual files.

Eoin Clerkin authored 3 years ago and Florian Uhlig committed 3 years ago

Ensures that modified .cpp, .C and .h files follow basic licence header guidelines.

Check line 1 for a copyright declaration with correct numerial and character placements for a date followed by institute and city.
Check line 2 for SPDX licence identifier.
Check line 3 for author and committer information.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Inserts the declaration on the 1st or 2nd line of scripts.

EMPTY LINE

Short license declarations for .sh files

Inserts the declaration on the 1st or 2nd line of scripts.

EMPTY LINE

Revert "Short license declarations for .sh files"

This reverts commit d3dd8608.

Uses SPDX identifier

Modifies declaration to use SPDX license identifier syntax

Corrects file

Empty line before hashbang removed

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

There was a problem with the script such that in some cases to many code
owners were informed. When in between the creation of the MR and the
runtime of the script the master branch of the official repository was
updated the code owners of the MR changes as well as the code owners of
the updated code from the official repository wer informed.
To avoid sending information for code which is already implemented in the
official repository the local working copy is rebased before extracting the
changed files.

Fix user name of Sergey Gorbunov in CODEOWNERS file. Sergey has two GitLab
accounts and the wrong was chosen.

Florian Uhlig authored 4 years ago and Volker Friese committed 4 years ago

Implement code owner functionality for our CI. Code owners are identified on a directory base by a look-up file. They are notified when changes to their code included in a MR.

According to the Posix standard a line of a text is defined as follows:

3.206 Line
A sequence of zero or more non- <newline> characters plus a terminating
<newline> character.

The test checks if this is valid for all newly added or changed text files.

I stumbeled over the issue when adding a new header file the list of header
files used to generate a ROOT dictionary.
The previous last file of the list did not have a proper file ending and
attaching the new header file results in a ROOT dictionary source code with
the following line

'#endif#ifdef'

which could be properly parsed and compiled by the compiler but results in an
error at run time when loading the library.

To avoid such problems in future the test was added.

Only files with unix style file endings should eneter the repository.
Add a CI stage which fails if the file type of a changed file is dos.
Add a script which executes the actaul test.

Load a single library to check if there is some dependency missing.

Only run the piplines when there is a MR to the master branch.
Properly connect the official CbmRoot repository for the format checker
such that the differing source files can be found.
Add a shell script to do this.

Add script to format all source/header files in one go.