Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Remove obsolete, unneeded and unused code.

Cornelius Feier-Riesen authored 3 years ago and Florian Uhlig committed 2 years ago

add new PLUTO path (Tetyanas folder)
add purity histograms
add histograms to investigate diff. between PLUTO/UrQMD and electron/positron
add CB histograms in LmvmDraw.cxx
add histogram to investigate BG and its sources
add histosgrams for acc and rec. pions and electrons for var. detector
combinations
some more small changes

Fix deprecation warnings about upercase log levels. Use lowercase ones.

Fix ambiguous function call.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- Move implementation of CbmMuchAddress::SetElementId to cpp file
- Move Logger include from header to cpp
- Add missing Logger include to CbmMuchSignal cxx file
- Add missing Logger include to CbmAnaDimuonAnalysis cxx file (needed only for FS/FR jun19-v18.2)

Induced by inclusion in DigiData of the other detectors on top of STS (needed only for FS/FR higher than FS/FR jun19-v18.2)

Cornelius Feier-Riesen authored 3 years ago and Florian Uhlig committed 3 years ago

and also change nofBins of hTofM2 histogram.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add missing library dependencies and link directories.
Remove obsolete library dependencies and include/link directories.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

There was a circular dependency between Littrack and CbmRichReco. The problem
only shows up when linking an executable.
The dependency could be resolved by moving some of the rich code into the
directory core/detectors/rich and splitting the littrack library into two parts.
The first library (Littrack) contains everything beside the littrack QA classes
and the second one (LittrackQA) contains only the QA code. Those files moved
from reco/detectors/rich had no dependencies to reco or sim.

Sergey Gorbunov authored 3 years ago and Volker Friese committed 3 years ago

remove resets of the random seed from the compiled code. We should keep the ability to reproduce all the results when a non-zero seed is set in the main macro

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

Cornelius Feier-Riesen authored 3 years ago and Florian Uhlig committed 3 years ago

	modified:   analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTaskDrawAll.cxx
	modified:   macro/analysis/dielectron/batch_job.py
	modified:   macro/analysis/dielectron/batch_send_common.py
	modified:   macro/analysis/dielectron/draw_all.py
	modified:   macro/analysis/dielectron/hadd_many.py
	modified:   macro/analysis/dielectron/run_analysis.C
	modified:   macro/analysis/dielectron/run_litqa.C
	modified:   macro/analysis/dielectron/run_reco.C