Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

With commit 892f01a1 from 23.03.22 the layout
of the data class CbmTsEventHeader was changed by adding a new data member. At
that time it was forgotten to also increase the version number. This commit
increases the version number and corrects the issue.

Updated README.md to include instructions regarding the -p and -a options of config.sh and config.csh.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Restructure code in the main CMakeLists.txt

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which does some basic checks into separate CMake file.
Some additional reordering of the code is needed.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which defines the compiler settings into separate CMake file.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which defines additional targets into separate CMake file.
Move code which generates the config files into separate CMake file.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Check if environmnet variables SIMPATH and FAIRROOTPATH are set or if the paths
are passed on the commandline as -DSIMPATH=<path to FairSoft installation>
-DFAIRROOTPATH=<path to FairRoot installation> early during the cmake run.
After the initial check only the CMake variables are used.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Don't require environmnet variables SIMPATH and FAIRROOTPATH when building
flesnet and NicaFemto. Pass the corresponding CMake variables to the build
processes of the packages.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Remove obsolete, unneeded and unused code.

Dominik Smith authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Unpack Much: Applied Epoch cycle fix. Fixed MacOS compilation (variable-sized array). Fixed missing Elink parameters.

- Prevent FairrootManager from touching the source object trhogh its pointer after the run is over
- Explicitely delete the dynamically allocated Run and Source objects in the macro (give up share ownership of config objects)
- Give up ownership of the config objects, which triggers their destruction before reaching end of the macro (last owner of shared pointer)

Problem was that the FairrootManager was never going out of scope and was not calling the Source destructor.
So all shared pointers and the source objects were destroyed only when going out of scope in the ROOT session, at which time ROOT already deleted some TF1's, THx's and Canvases without asking anybody (global Lists).
The source and config destructors were then calling destructors for their members and member's members, where we tried to cleanup the memory we assigned but which ROOT already deleted.