Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

All transport macros now properly depend on run_cleanup.

Remove duplicate entries for json config tests.

Revert some changes which were introduced with 01e5e5ae but overwritten
with 827c8050.

Run tests for all defined setups.
With commit e6c87d7a (MR !646) many new setups for APR21 and DEC21 were added.
Unfortunately the generated file names weren't changed accordingly. This
results in a situation that not all defined setups were executed.
As example in the case of three setups with the names
sis100_electron, sis100_electron_APR21 and sis100_electron_DEC21 only one
setup was tested. This was either the first or the last defined setup.
Now all defined setups are tested which increases the number of test in the
run directory from 63 to 111.

Use the correct TGeo unit system.
Use TVolume->Export to store the RICH volume in the ROOT file.
Add the correct placement matrix according to the shift of the coordinate
system.
Also create the file needed for the media check.
Create all needed materials prior to the import from the gdml file such that
they are properly exported to the ROOT file

- Replace the squares by explicite multiplications to avoid version dependent awk error
- Filter out the `vacuum` material defined with e-18 Z
- Fix tab printout

Only create the geometry file with exported geometry and placement matrix.
Use correct unit system.
Create also the file needed for the media check.

Administrator authored 3 years ago and Volker Friese committed 3 years ago

Allow to overwrite existing files. This is needed for the CI since the rerun
of failing transport macros wil fail otherwise in any case due to the already
existing output file.
The default setting in the transport macros is to not overwrite existing
files. The CI uses a paramter to change the default.

Administrator authored 3 years ago and Volker Friese committed 3 years ago

Clean the data directories before running the test in the mvd, much and mcbm
directories.
Fix test dependencies in several directories.
Add json config file for CI tests which writes output in the data directory
such that the files are properly deleted when running the next tests.

fix of RICH unpacker v3 following bugfix in CRI firmware + add Tot correction for DiRICHes missing in 1588

Eoin Clerkin authored 3 years ago and David Emschermann committed 3 years ago

New tags are needed to regenerate binaries that were used
but have wrong radiation length defined for materials.

Script which checks the radiation lenght of materials in a
user specified geometry, i.e. test.geo.root

Counts failures. Reports errror code.

Beampipe v21e has a maximum deflection of the downstream section to conical section which is consistent with a 2AGeV gold beam.

Beampipe v21f has no field and so is in the non-deflected state.

Adds licence headers

Outputs v21e to root binary

Made Media Names consistent with media.geo

Appies Clang format rules

Propper material definitions in accordance with the mediafile

Corrects the names of the top volumes

Repaired CLANG format in both files

Beampipes with bellows, wide conical section and downstream cylinder

Beampipe v21e has a maximum deflection of the downstream section to conical section which is consistent with a 2AGeV gold beam.

Beampipe v21f has no field and so is in the non-deflected state.

Adds licence headers

Outputs v21e to root binary

Made Media Names consistent with media.geo

Appies Clang format rules

Propper material definitions in accordance with the mediafile

Corrects the names of the top volumes

Repaired CLANG format in both files

Beampipes with bellows, wide conical section and downstream cylinder

Beampipe v21e has a maximum deflection of the downstream section to conical section which is consistent with a 2AGeV gold beam.

Beampipe v21f has no field and so is in the non-deflected state.

Adds licence headers

Outputs v21e to root binary

Made Media Names consistent with media.geo

Appies Clang format rules

Propper material definitions in accordance with the mediafile

Corrects the names of the top volumes

Repaired CLANG format in both files

Beampipes with bellows, wide conical section and downstream cylinder

Beampipe v21e has a maximum deflection of the downstream section to conical section which is consistent with a 2AGeV gold beam.

Beampipe v21f has no field and so is in the non-deflected state.

Adds licence headers

Outputs v21e to root binary

Made Media Names consistent with media.geo

Appies Clang format rules

Propper material definitions in accordance with the mediafile

Corrects the names of the top volumes

Repaired CLANG format in both files

CLANG format check passed for both files

Resolves the namimng convention

resolves the CLANG check failure

removed empty lines to trigger pipeline

CLANG format correction

Eoin Clerkin authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Copied corrections by Ingo in gitlab comment

!617

Removed Window linebreaks

Norbert Herrmann authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Apply clang-format. uncomment TofSimpClusterizer constructor

  - cbmroot/reco/L1/L1Algo/L1BaseStationInfo.h:
    > a prototype of user-friendly interface to L1Station and other geometry inputs to L1Algo (experimental)
    > added setters and getters for L1Station data fields
    > added calculation of hidden L1Station properties
    > added Print() method
  - cbmroot/reco/L1/L1Algo/L1Parameters.h:
    > add new compile time constants: kMaxNFieldApproxCoefficients, kStationBits, kThreadBits, kTripletBits,
      kMaxNstations, kMaxNthreads, kMaxNtriplets
    > add new runtime "constants": fMaxDoubletsPerSinglet, fMaxTripletPerDoublets
    > add Print() method
  - cbmroot/reco/L1/L1Algo/L1Algo.h:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1Algo.cxx:
    > add L1Parameters::Print() call from L1Algo::Init()
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1CATrackFinder.cxx:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1TrackFitter.cxx:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1Field.h:
    > magic constant '21' changed to L1Parameters::kMaxNFieldApproxCoefficients (compile time)
  - cmbroot/reco/L1/CbmL1.h:
    > add a L1Paramters class field (currently ptr to address in the heap) to CbmL1
    > add getter for the L1Parameters class field to CbmL1
  - cbmroot/reco/L1/CbmL1.cxx:
    > add transfer of the L1Parameters data from CbmL1 to L1Algo
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/macro/run/run_reco.C:
    > add example of L1Algo runtime constants modification

pipe_v16e_1e is the shifted pipe_v16b_1e by creation of node.
pipe_v20b_1m is the shifted pipe_v20a_1m
sts_v20a is the shifted sts_v19a geometry
much_v20c_sis100_1m_lmvm is shifted lmvm verison of v20a
much_v20c_sis100_1m_jpsi is shifted version of v20a
trd_v20c_1(e,h,m_ is the shifted trd_v20b_1(e,h,m)
tof_v20c_1(e,h,m) is the shifted tof_v20b_1(e,h.m)
psd_v20c is the shifted psd_v20a

Geometries without macros are manually shifted by editing of their TFile.

Updates external repos tags
For geometry, parameter and input repos.
Updated tags in switch_defaults.sh.
run_tra_(file|beam).C now positions the target dependent on the setup file chosen.

Updates README.md file in macro/geometry directory.

Adds standard tra, digi, and reco ctest for origin redefinition
and DEC21 candidate geometries for the electron and hadron setups.

Allows a non standard install directory for cbmroot.

Updates the geometry repository tags.

Mehulkumar Shiroya authored 3 years ago and Florian Uhlig committed 3 years ago

There are four sts beampipe macros to include to use them along with the new
sts geometries

beampipe_v21a: Old beampipe, can only be used with sts geometry version: sts_v21[a].

beampipe_v21b: New beampipe. It has 40mm diameter upstream side and 104mm diameter (including cylindrical part) downstream side.
This beampipe can be used with the sts geometry version: sts_v21[b, d, f, h].

beampipe_v21c: New beampipe. It has 55mm diameter upstream side and 104mm diameter(including cylindrical part) downstream side.
This beampipe can be used with the sts geometry version: sts_v21[c].

beampipe_v21d: New beampipe. It has 40mm diameter upstream side and 104 diameter(including cylindrical part) downstream side.
This beampipe can be used with the sts geometry having a target position at -44 cm. which means it can only be used with the
sts geometry vesrion: sts_v21[e, g, i].

Volker Friese authored 3 years ago and Florian Uhlig committed 3 years ago

Correct CbmDaq to provide the proper MC event list. Prevent tree access modes kRepeat and kRandom for the time being.

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

In TOF unpacker, make the 2021 epoch hack controlable and disable it by default + enable in unpack macro for old runs

Cornelius Feier-Riesen authored 3 years ago and Florian Uhlig committed 3 years ago

and also change nofBins of hTofM2 histogram.