sergeizharko authored 3 years ago and David Emschermann committed 3 years ago

  - cbmroot/reco/L1/L1Algo/L1BaseStationInfo.h:
    > a prototype of user-friendly interface to L1Station and other geometry inputs to L1Algo (experimental)
    > added setters and getters for L1Station data fields
    > added calculation of hidden L1Station properties
    > added Print() method
  - cbmroot/reco/L1/L1Algo/L1Parameters.h:
    > add new compile time constants: kMaxNFieldApproxCoefficients, kStationBits, kThreadBits, kTripletBits,
      kMaxNstations, kMaxNthreads, kMaxNtriplets
    > add new runtime "constants": fMaxDoubletsPerSinglet, fMaxTripletPerDoublets
    > add Print() method
  - cbmroot/reco/L1/L1Algo/L1Algo.h:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1Algo.cxx:
    > add L1Parameters::Print() call from L1Algo::Init()
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1CATrackFinder.cxx:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1TrackFitter.cxx:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1Field.h:
    > magic constant '21' changed to L1Parameters::kMaxNFieldApproxCoefficients (compile time)
  - cmbroot/reco/L1/CbmL1.h:
    > add a L1Paramters class field (currently ptr to address in the heap) to CbmL1
    > add getter for the L1Parameters class field to CbmL1
  - cbmroot/reco/L1/CbmL1.cxx:
    > add transfer of the L1Parameters data from CbmL1 to L1Algo
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/macro/run/run_reco.C:
    > add example of L1Algo runtime constants modification

sergeizharko authored 3 years ago and David Emschermann committed 3 years ago

L1Parameters.h: new file ; L1BaseStationInfo.h: getters and setters added; L1Station.h: minor modifications; L1Field.h: magic constant '21' changed to the constexpr parameter L1Parameters::kN_FS_COEFFS

sergeizharko authored 3 years ago and David Emschermann committed 3 years ago

  - cbmroot/reco/L1/L1Algo/L1BaseStationInfo.h:
    > a prototype of user-friendly interface to L1Station and other geometry inputs to L1Algo (experimental)
    > added setters and getters for L1Station data fields
    > added calculation of hidden L1Station properties
    > added Print() method
  - cbmroot/reco/L1/L1Algo/L1Parameters.h:
    > add new compile time constants: kMaxNFieldApproxCoefficients, kStationBits, kThreadBits, kTripletBits,
      kMaxNstations, kMaxNthreads, kMaxNtriplets
    > add new runtime "constants": fMaxDoubletsPerSinglet, fMaxTripletPerDoublets
    > add Print() method
  - cbmroot/reco/L1/L1Algo/L1Algo.h:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1Algo.cxx:
    > add L1Parameters::Print() call from L1Algo::Init()
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1CATrackFinder.cxx:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1TrackFitter.cxx:
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/reco/L1/L1Algo/L1Field.h:
    > magic constant '21' changed to L1Parameters::kMaxNFieldApproxCoefficients (compile time)
  - cmbroot/reco/L1/CbmL1.h:
    > add a L1Paramters class field (currently ptr to address in the heap) to CbmL1
    > add getter for the L1Parameters class field to CbmL1
  - cbmroot/reco/L1/CbmL1.cxx:
    > add transfer of the L1Parameters data from CbmL1 to L1Algo
    > modifications according to the constants transfer to the L1Parameters class (example: fkMaxNthreads ==> L1Parameters::kMaxNthreads)
  - cbmroot/macro/run/run_reco.C:
    > add example of L1Algo runtime constants modification

sergeizharko authored 3 years ago and David Emschermann committed 3 years ago

L1Parameters.h: new file ; L1BaseStationInfo.h: getters and setters added; L1Station.h: minor modifications; L1Field.h: magic constant '21' changed to the constexpr parameter L1Parameters::kN_FS_COEFFS

Dominik Smith authored 3 years ago and Volker Friese committed 3 years ago

BuildRawEvents (task and algo) now filters T0 digis from the Tof stream using their address (also for QA and seed finder).

Dominik Smith authored 3 years ago and Volker Friese committed 3 years ago

CbmSeedFinderQa and CbmBuildEventsQa: All links are now assigned the same weight when obtaining event matches from digi matches, since different detectors don't use the same scale.

In the input repository many files for the media checks were added.
In the geometry repository the rich geometry v21a was corrected.
The geometry now has the correct name and the correct radiation length
of the materials.

Use the correct TGeo unit system.
Use TVolume->Export to store the RICH volume in the ROOT file.
Add the correct placement matrix according to the shift of the coordinate
system.
Also create the file needed for the media check.
Create all needed materials prior to the import from the gdml file such that
they are properly exported to the ROOT file

- Replace the squares by explicite multiplications to avoid version dependent awk error
- Filter out the `vacuum` material defined with e-18 Z
- Fix tab printout

Only create the geometry file with exported geometry and placement matrix.
Use correct unit system.
Create also the file needed for the media check.

Use also for macosx 11 the latest FairSoft and FairRoot release versions# Please enter the commit message for your changes. Lines starting

Remove Debian8 systems from the CI pipeline.
Use FairSoft apr21p2 and FairRoot v18.6.7 for tests.

Dominik Smith authored 3 years ago and David Emschermann committed 3 years ago

Modified CbmBuildEventsQa and QA function in CbmSeedFinderSlidingWindow to treat digis with empty matches as noise.

Administrator authored 3 years ago and Volker Friese committed 3 years ago

Allow to overwrite existing files. This is needed for the CI since the rerun
of failing transport macros wil fail otherwise in any case due to the already
existing output file.
The default setting in the transport macros is to not overwrite existing
files. The CI uses a paramter to change the default.

Administrator authored 3 years ago and Volker Friese committed 3 years ago

Clean the data directories before running the test in the mvd, much and mcbm
directories.
Fix test dependencies in several directories.
Add json config file for CI tests which writes output in the data directory
such that the files are properly deleted when running the next tests.

Administrator authored 3 years ago and David Emschermann committed 3 years ago

Get the number of CPUs also on macosx.
Allow to define the number of used processes as command line parameter.

Administrator authored 3 years ago and David Emschermann committed 3 years ago

Move code into functions to get a clean main routine.
Add checking of prerequisites before compilation.
Add support for FairSoft versions after jun19 since these FairSoft
versions require a different build scheme.

Add CBM specific install instructions for OpenSuse and Fedora for
for packages which are not covered by the FairSoft documentation.
This is sqlite3 which is only needed by CBM and tbb and gsl which
showed problems on newer systems recently.