Felix Weiglhofer authored 1 year ago and Florian Uhlig committed 1 year ago

Generate the file algo/base/BuildInfo.cxx at compile time containing
various information like git commit and build configuration.

Eoin Clerkin authored 2 years ago and Florian Uhlig committed 2 years ago

Record the hash and date of the build and report these at build and configuration times.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Remove obsolete files containing macros which were needed before the build
system was moderinsed. The only macro which is still needed was added in
the file CbmMacros.cmake.

Felix Weiglhofer authored 2 years ago and Florian Uhlig committed 2 years ago

Replace usage of deprecated LIBRARY_OUTPUT_PATH variable with newer CMAKE_LIBRARY_OUTPUT_DIRECTORY.
The new variable has the advantage that it populates the LIBRARY_OUTPUT_DIRECTORY property of targets.
This property is required by xpu to figure out where the generated cuda/hip libraries should be placed.

Remove a special linker setting for macosx which isn't needed any longer.
With the build system changes the full list of dependecies is available at
link time.
Add a missing library dependency.

Switch of specific compiler warnings when compiling rootcling generated
dictionary code otherwise the output is spammed with a huge number of warnings.
The code is generated by rootcling and we can't do anything to fix the
problems.

Use the same target names as provided by FairRoot with version v18.8.

Add the new target FairRoot::Online which is a new library conatining the
online related code which was previously part of the Base library.
In case of older FairRoot versions the target is only an alias for the target
FairRoot::Base such that the same dependencies already work with FairRoot
v18.6 which is our current default version.

Add the new target FairRoot::Online in all CMakeLists.txt where it is needed.

The FindFairRoot macro is also used when compiling NicaFemto. Since there is a
problem with the target definitions in NicaFemto the targets are not defined
when compiling NicaFemto.

Omveer Singh authored 2 years ago and Florian Uhlig committed 2 years ago

print_info() macro added to CbmMacro.cmake module
unnecessary variables removed

Makes clear to reader that append is default. Allows
previous overwrite option.

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

The header files from subdirectories were expected by ROOT in the wrong
directory structure. Pass the header files without the path  when generating
the dictionary.

Rootmap and pcm files are copied into library directory

Using exported target via target_link_libraries()
Include directories are added to a target via target_include_directories()
Generating installation rules for a target and corresponding files via install()

Using NAMESPACE, different targets are created.
FairRoot::FairTools
FairRoot::Alignment
FairRoot::ParBase
FairRoot::GeoBase
FairRoot::MbsAPI
FairRoot::Base
FairRoot::EventDisplay
FairRoot::TrkBase
FairRoot::Gen
FairRoot::BaseMQ
FairRoot::ParMQ
FairRoot::Geane

The FindPackage module files are not needed any longer. The packages are now
found using the CMake config files installed by the packages themself.

Use cmake FindPackage config files instead of the self written FindPackage
module files.
The FindPackage config files are created by the developers themself and
installed with external dependencies.

Add missing CMake variables which are not defined any longer by the self
written FindPackage module files.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

Due to some changes in CbmRoot recently the existing PATH and LD_LIBRARY_PATH
variable were overwritten when sourcing the config scripts (config.sh and
config.csh) whithout additional parameter -a or -p.
This commit change the default setting such that the new paths are appended to
the existing PATH and (DY)LD_LIBRARY_PATH.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

Do some Minor fixes.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

To become independent from the FairRoot macros and scripts, simply add the
needed macros in cmake/modules and input needed to generate the scripts
into cmake/scripts.

Change copied macros such that the input needed to generate the scripts is
taken from the local cmake/scripts directory.

Avoid a problem if the CMake variable ${CPUINFO} is empty.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which does some basic checks into separate CMake file.
Some additional reordering of the code is needed.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which defines the compiler settings into separate CMake file.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which defines additional targets into separate CMake file.
Move code which generates the config files into separate CMake file.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Check if environmnet variables SIMPATH and FAIRROOTPATH are set or if the paths
are passed on the commandline as -DSIMPATH=<path to FairSoft installation>
-DFAIRROOTPATH=<path to FairRoot installation> early during the cmake run.
After the initial check only the CMake variables are used.

Inserts the declaration on the 1st or 2nd line of scripts.

EMPTY LINE

Short license declarations for .sh files

Inserts the declaration on the 1st or 2nd line of scripts.

EMPTY LINE

Revert "Short license declarations for .sh files"

This reverts commit d3dd8608dead032b12bc71798a2bd97bfca95442.

Uses SPDX identifier

Modifies declaration to use SPDX license identifier syntax

Corrects file

Empty line before hashbang removed

The previous fix did not work for macosx 11.3. Somehow on this system the old
FindGEANT3.cmake file was used.
Probably this is not a problem with the macosx version but with the usage of
a case insensitive file system. To avoid the problem remove the old and
obsolete file.
Also do some fixes to properly initialise some cmake variables.

Administrator authored 4 years ago and Florian Uhlig committed 3 years ago

Cleanup filtering of compiler warnings for Nightly tests

Remove unused variables, parameters and data members.
Remove move statement to allow copy ellision.
Use unsingned int in loop when comparing with size function of containers.
Initialize all data members.

Fix warning from rootcling.
With newer root versions the parameter -c isn't supported any longer,
so remove it.

When installing CbmRoot using FairRoot v18.4 and FairSoft there was a problem
with the location of header files when executing macros. Some of the header
files couldn't be found which for some of them worked with printing warning
or error messages only. For other header files the macros simply crashed with
error messages about not found header files. It is unclear if this is a
FairRoot or Root issue but I would guess it is a Root problem.
The issue was solved by simply removing the path from the header file name when
generating the Root dictionary. In this case it is enough to specify the
directory where all header files are installed when running Root using the
environment variable ROOT_INCLUDE_PATH.

In some of the build system files missing directories where added such that
the dictionaries could be produced properly.

Convert files with wrong format to unix style line breaks.