Skip to content
Snippets Groups Projects
Commit 32dc60a3 authored by Pierre-Alain Loizeau's avatar Pierre-Alain Loizeau
Browse files

QA core: make errors from CbmQaTask::CheckRange clearer for non-experts

parent bc635aca
No related branches found
No related tags found
1 merge request!1616Make detection of geo setups to check more granular + bump geo hash
Hide whitespace changes
Inline Side-by-side
Showing
with 8 additions and 4 deletions
core/qa/CbmQaTask.h
+ 8
− 4
View file @ 32dc60a3
...@@ -281,15 +281,19 @@ bool CbmQaTask::CheckRange(std::string_view name, T var, T varErr, T lo, T hi) c ...@@ -281,15 +281,19 @@ bool CbmQaTask::CheckRange(std::string_view name, T var, T varErr, T lo, T hi) c
{ {
bool ret = true; bool ret = true;
if (var + 3.5 * varErr < lo) { if (var + 3.5 * varErr < lo) {
LOG(error) << fName << ": " << name << " is found to be under the lower limit (" << var << " +-" << varErr << " < " LOG(error) << fName << ": " << name << " is found to be under the lower limit (" << var << " +- 3.5 x " << varErr
<< lo << ')'; << " < " << lo << ')';
ret = false; ret = false;
} }
if (var - 3.5 * varErr > hi) { if (var - 3.5 * varErr > hi) {
LOG(error) << fName << ": " << name << " is found to be above the upper limit (" << var << " +-" << varErr << " > " LOG(error) << fName << ": " << name << " is found to be above the upper limit (" << var << " +-3.5 x " << varErr
<< hi << ')'; << " > " << hi << ')';
ret = false; ret = false;
} }
if (ret) {
LOG(debug) << fName << ": " << name << " is found to be within limit (" << lo << " <= " << var << " +- 3.5 x "
<< varErr << " <= " << hi << ')';
}
return ret; return ret;
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment