From 32dc60a3076b6f96324fc394cf0457e2379b3a1b Mon Sep 17 00:00:00 2001
From: P-A Loizeau <p.-a.loizeau@gsi.de>
Date: Fri, 2 Feb 2024 15:33:04 +0100
Subject: [PATCH] QA core: make errors from CbmQaTask::CheckRange clearer for
non-experts
---
core/qa/CbmQaTask.h | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/core/qa/CbmQaTask.h b/core/qa/CbmQaTask.h
index c13ff090fd..e2df685e05 100644
--- a/core/qa/CbmQaTask.h
+++ b/core/qa/CbmQaTask.h
@@ -281,15 +281,19 @@ bool CbmQaTask::CheckRange(std::string_view name, T var, T varErr, T lo, T hi) c
{
bool ret = true;
if (var + 3.5 * varErr < lo) {
- LOG(error) << fName << ": " << name << " is found to be under the lower limit (" << var << " +-" << varErr << " < "
- << lo << ')';
+ LOG(error) << fName << ": " << name << " is found to be under the lower limit (" << var << " +- 3.5 x " << varErr
+ << " < " << lo << ')';
ret = false;
}
if (var - 3.5 * varErr > hi) {
- LOG(error) << fName << ": " << name << " is found to be above the upper limit (" << var << " +-" << varErr << " > "
- << hi << ')';
+ LOG(error) << fName << ": " << name << " is found to be above the upper limit (" << var << " +-3.5 x " << varErr
+ << " > " << hi << ')';
ret = false;
}
+ if (ret) {
+ LOG(debug) << fName << ": " << name << " is found to be within limit (" << lo << " <= " << var << " +- 3.5 x "
+ << varErr << " <= " << hi << ')';
+ }
return ret;
}
--
GitLab