Add geometry and parameter files for tof_v20b.
The geometry tof_v20b fixes an issue with tof_v20a found at 18.04.21. The number of chanels per module and also some module types were wrong. For consisteny reasons the existing geometry tof_v20a wasn't changed but a new fixed one tof_v20b was created. The macro used for the generation of the tof_v20 geometries was commited with 0a48b9fc. The complete disscusions about the new geometry are at !314 (merged) CbmSoft/cbmroot_geometry!83 (merged)
Merge request reports
Activity
changed milestone to %APR21
- Resolved by Eoin Clerkin
please check if the commit message is telling enough.
added 8 commits
-
6e226cc9...5662d267 - 7 commits from branch
computing:master
- 00cd9350 - Add geometry and parameter files for tof_v20b.
-
6e226cc9...5662d267 - 7 commits from branch
Dear @f.uhlig,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Florian Uhlig
I think we should update the tof version in the config.json used in run_transport_json_config.C. Is this a good place to include it or should a separate commit be made?
Comments from @o.golosov and @f.uhlig ?
No objections from my side. Just to clarify: you do not have to list all the detector tags explicitly in the json-config. These parameters are optional and may be removed in case you want to use one of default setups (e.g. sis100_electron). I placed them in the example config file just for the users to be aware of such an option.
added 3 commits
-
00cd9350...475cf359 - 2 commits from branch
computing:master
- 15c065f0 - Updates cmake tags to include geometry and parameter files for tof_v20b.
-
00cd9350...475cf359 - 2 commits from branch