Add macro to create tof geometry tof_v20b

We decide to keep the old geometry v20a for consistency and create instead a new geometry tag v20b for the default tof geometry. To be consistent we also have to revert to the old version of the macro.

@n.herrmann,

as discussed today in our developers meeting we decided to keep the old tof geometry v20a for consistency reasons and add a new tof geometry v20b which is a copy of your last changes to v20a with a different tag.

Could you please cross check the macro for the creation of the tof_v20b geometry. Toi test the creation macros myself I did simulation runs with the geo files from your MR CbmSoft/cbmroot_geometry!82 (closed) and the geo files created by me with the geo files from my MR CbmSoft/cbmroot_geometry!83 (merged). The results from the simulations are identical such that I am confident that I didn't made any error.

The corresponding parameter files are in my MR CbmSoft/cbmroot_parameter!36 (closed)

Dear @n.herrmann, @i.deppner,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

assigned to @e.clerkin

requested review from @v.friese

assigned to @v.friese and unassigned @e.clerkin

requested review from @e.clerkin and removed review request for @v.friese

approved this merge request

Here is the difference between to new create_v20a macro and old Dec version after a putting in the same format. The fourth change was obviously in my local macro to get it to run, just omitted in my commit. The first 3 are the changes. I would suggest a new version tag for this geometry.

May I query from @n.herrmann, @i.deppner that this is what is desired?

[1]

< const Int_t NumberOfReadoutStrips[NumberOfDifferentCounterTypes] = {32, 32, 64, 64};
> const Int_t NumberOfReadoutStrips[NumberOfDifferentCounterTypes] = {32, 32, 32, 32};

[2]

< const Double_t Inner_Module_Types[Inner_Module_NTypes]  = {4., 3., 0.};
> const Double_t Inner_Module_Types[Inner_Module_NTypes]  = {4., 5., 6.};

[3]

< const Double_t Inner_Module_Number[Inner_Module_NTypes] = {2., 2., 6.};  //V13_3a
> const Double_t Inner_Module_Number[Inner_Module_NTypes] = {2., 2., 4.};  //V13_3a

[4]

< void Create_TOF_Geometry_v16e()
> void Create_TOF_Geometry_v20a()

[5]

< cout << "Place Mod Type " << j << " at x " << xPos << ", y " << yPos << ", z " << zPos << ", Flip "
> cout << "Place Mod " << i << " of Type " << j << " at x " << xPos << ", y " << yPos << ", z " << zPos << ", Flip "

@e.clerkin,

these are exactly the changes which are in Create_TOF_Geometry_v20b.C

@v.friese,

in the list of changes I see that you approved the MR but unfortunately I don't see that the Approve button is changed to 'Approve additionally'. Do you see that you have approved when checking the web page?

Title of this merge request should be changed to v20b

changed title from Add macro to create tof geometry tof_v20a to Add macro to create tof geometry tof_v20b

changed the description

changed milestone to %APR21

added 5 commits

• 1ce443c5 - 1 commit from branch computing:master
• 58108a7c - Revert to previous version of Create_TOF_Geometry_v20a.C
• 5503b942 - Add new macro Create_TOF_Geometry_v20b.C
• d7addf69 - Apply clang-format
• dfafb152 - Fix name of the main function

Compare with previous version

resolved all threads

merged