WIP: Add gFile + gDirectory protection in all tasks

Store and restore gFile abd gDirectory around each new TFile not yet protected.

Exception: star2019 code not touched as potential modifications from running experiment pending

=> Many files modified, so we should get approval from a few developers to make sure I did not break anything (Approve button)

added 1 commit

• 2b835ea6 - Apply clang-format

Compare with previous version

added 13 commits

• 2b835ea6...6d929846 - 5 commits from branch computing:master
• 44398cbf - Restore the gitignore file in mcbm2020 macro folder
• b03aa766 - Add gFile + gDirectory protection in sim classes
• fe0e3f3d - Add gFile + gDirectory protection in reco/detector classes
• 937d48f8 - Add gFile + gDirectory protection in other reco classes
• 00b8cf7a - Add gFile + gDirectory protection in MQ+core+mvd classes
• 956e98a8 - Add gFile + gDirectory protection in fles/mcbm2018 classes
• eb923fad - Add gFile + gDirectory protection in analysis classes
• c90d63ea - Apply clang-format

Compare with previous version

added 14 commits

• c90d63ea...fac1510e - 6 commits from branch computing:master
• c5aec1cb - Restore the gitignore file in mcbm2020 macro folder
• 40ec7374 - Add gFile + gDirectory protection in sim classes
• ed3a6c1c - Add gFile + gDirectory protection in reco/detector classes
• cee4d3a1 - Add gFile + gDirectory protection in other reco classes
• 56b8e684 - Add gFile + gDirectory protection in MQ+core+mvd classes
• c0fb5885 - Add gFile + gDirectory protection in fles/mcbm2018 classes
• 96ef3f28 - Add gFile + gDirectory protection in analysis classes
• 5f293a5b - Apply clang-format

Compare with previous version

added 15 commits

• 5f293a5b...344dce4d - 7 commits from branch computing:master
• 136e0d17 - Restore the gitignore file in mcbm2020 macro folder
• 608d5e6a - Add gFile + gDirectory protection in sim classes
• 32d623bf - Add gFile + gDirectory protection in reco/detector classes
• 499a159c - Add gFile + gDirectory protection in other reco classes
• 4b067ab1 - Add gFile + gDirectory protection in MQ+core+mvd classes
• c4736d29 - Add gFile + gDirectory protection in fles/mcbm2018 classes
• 0fa1dc1c - Add gFile + gDirectory protection in analysis classes
• 9c7300ae - Apply clang-format

Compare with previous version

Hi @p.-a.loizeau,

I again looked at the changes. For me this is all fine but since code in so many places was changed I fear that this MR is much too large to be integrated easily.

Since all changes are independent I would propose to break this MR in several smaller ones, e.g. one per subsystem, PWG or whatever separation make sense and assign these dedicated MRs then to proper reviewers.

I will try to do this still today or at least tomorrow.

mentioned in merge request !229 (merged)

Indeed, that will be far easier to assign for reviews, I partially split the commits but did not think about this... I guess I am still not yet used to using git branches to split changes in more manageable blocks ^^'

I approved and merged the FLES one.

assigned to @praisig and unassigned @f.uhlig

assigned to @f.uhlig and unassigned @praisig

approved this merge request

Close this MR. The large amount of changed files was distributed to several smaller MRs which could be assigned to a small group of developers for approval.

All the changes were applied in the following merge requests:

!283 (merged), !282 (merged), !280 (merged), !279 (merged), !278 (merged), !277 (merged), !260 (merged), !235 (merged), !232 (merged), !230 (merged) and !229 (merged)

closed