Draft: Add optional YAML config for MUCH online unpacker
Of Interest to @v.singhal @c.ghosh_AT_vecc.gov.in
Goal of MR: check that code is compatible with CI in order to prepare local merging with parallel changes to the MUCH online unpacker
=> cleaner MR will come after beamtime or this one will be strongly reviewed/edited
=> DO NOT TAKE OUT OF DRAFT MODE PLEASE!
Will need CbmSoft/cbmroot_parameter!243 to be applied to mCBM 2025 data
Partially colliding with !2097 so one of the two would need to be locally rebased depending on which one is merged first
Merge request reports
Activity
added Online Parameters mCBM labels
assigned to @p.-a.loizeau
added 1 commit
- 0138ffd4 - TEMP: try to add optional YAML config for MUCH online unpacker
requested review from @s.zharko
added 13 commits
-
0138ffd4...35a75499 - 12 commits from branch
computing:master
- 717eaa52 - [algo] Add optional YAML config for MUCH online unpacker
-
0138ffd4...35a75499 - 12 commits from branch
added 1 commit
- f905742b - [algo] Add optional YAML config for MUCH online unpacker
added 1 commit
- ce382e40 - [algo] Add optional YAML config for MUCH online unpacker
Dear @d.smith, @fweig, @v.singhal,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
Take out of draft mode as ready to merge as is, as it is now compatible with the 2022 data (in the sense of having the same outcome as before this MR).
If CbmSoft/cbmroot_parameter!243 is approved before this one is merged, the hash update can be added here, but it is not mandatory and may be introduced in a later MR (e.g. in case revision of the parameters for 05/2025 is desired)
added 15 commits
-
ce382e40...f9e0943e - 14 commits from branch
computing:master
- fe791718 - [algo] Add optional YAML config for MUCH online unpacker
-
ce382e40...f9e0943e - 14 commits from branch
added 1 commit
- e6bd3310 - [algo] Add optional YAML config for MUCH online unpacker
mentioned in merge request !1185 (closed)
added 39 commits
-
e6bd3310...bd8f97bb - 38 commits from branch
computing:master
- dd523eaa - [algo] Add optional YAML config for MUCH online unpacker
-
e6bd3310...bd8f97bb - 38 commits from branch
mentioned in merge request CbmSoft/cbmroot_parameter!243
added 81 commits
-
dd523eaa...70b6746d - 79 commits from branch
computing:master
- 9da12ebe - [algo] Add optional YAML config for MUCH online unpacker !! Broken by rebase !!
- 2c656b0c - Fixes after rebase, not tested with real data yet
-
dd523eaa...70b6746d - 79 commits from branch
- Resolved by Pierre-Alain Loizeau
Removing draft mode as could now reproduce the checks from 3 months ago with the changes from CbmSoft/cbmroot_parameter!243:
- If no Much readout parameter filename provided in whichever
MainConfig.yaml
is used, hardcoded values from 2022-2024 are used instead - If Much readout parameter filename provided in whichever
MainConfig.yaml
is used points to a corrupt YAML file, hardcoded values from 2022-2024 are used instead - Parameter file from
02/2025
can be provided inMainConfig.yaml
and lead to no errors (for MUCH) - Parameter file from
05/2025
can be provided inMainConfig.yaml
and lead to no errors (for MUCH)
Ideally this should be merged after the parameters MR and with the corresponding has update, but it can also be done in the other order as the "default hardcoded values" feature anyhow corresponds to the current master behavior
- If no Much readout parameter filename provided in whichever
mentioned in merge request !2097