Skip to content
Snippets Groups Projects

Draft: Add optional YAML config for MUCH online unpacker

All threads resolved!

Of Interest to @v.singhal @c.ghosh_AT_vecc.gov.in

Goal of MR: check that code is compatible with CI in order to prepare local merging with parallel changes to the MUCH online unpacker
=> cleaner MR will come after beamtime or this one will be strongly reviewed/edited
=> DO NOT TAKE OUT OF DRAFT MODE PLEASE!

Will need CbmSoft/cbmroot_parameter!243 to be applied to mCBM 2025 data

Partially colliding with !2097 so one of the two would need to be locally rebased depending on which one is merged first

Edited by Pierre-Alain Loizeau

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 3 commits

    • de3a7e21 - 1 commit from branch computing:master
    • 814d066c - [algo] Add optional YAML config for MUCH online unpacker !! Broken by rebase !!
    • 48c8937b - Fixes after rebase, not tested with real data yet

    Compare with previous version

  • Pierre-Alain Loizeau resolved all threads

    resolved all threads

  • Removing draft mode as could now reproduce the checks from 3 months ago with the changes from CbmSoft/cbmroot_parameter!243:

    • If no Much readout parameter filename provided in whichever MainConfig.yaml is used, hardcoded values from 2022-2024 are used instead
    • If Much readout parameter filename provided in whichever MainConfig.yaml is used points to a corrupt YAML file, hardcoded values from 2022-2024 are used instead
    • Parameter file from 02/2025 can be provided in MainConfig.yaml and lead to no errors (for MUCH)
    • Parameter file from 05/2025 can be provided in MainConfig.yaml and lead to no errors (for MUCH)

    Ideally this should be merged after the parameters MR and with the corresponding has update, but it can also be done in the other order as the "default hardcoded values" feature anyhow corresponds to the current master behavior

  • Pierre-Alain Loizeau mentioned in merge request !2097

    mentioned in merge request !2097

  • Please register or sign in to reply
    Loading