Mvd online unpacker

ebbf0084...0a87288c - 25 commits from branch computing:master
3a1c54bf - initial mMVD unpacker
a6f87183 - added stuff for pulser analysis
cf93dd53 - Fix warnings in CbmMvdRawDigi
fd5d92f3 - Online: switch new setup from mMVD_Lab to mCBM2025_05
572e49a3 - Add missing mvd entry in online DigiEventQa
fef8da67 - add address scheme, handling mimosis raw data, modified CbmMvdRawDigi

Compare with previous version

@b.gutsche @ajit.kumar After merging Ajit latest changes, I did a rebase, which needed quite some backports in each commit due to the algo reorganisation by Sergei, and squashed most of the formatting and fixup commits

As this means that there were quite some changes even though the logic was kept, could I please ask the both of you to check if this branch combined with the param file from CbmSoft/cbmroot_parameter!242 (merged) are still working OK for you?

If everything is still fine with this version, I would put both MRs out of draft mode and try to get them in the master in the coming days

PS for @ajit.kumar: as I changed the remote branch history, if you want to add more changes before we merge you will need to reset your local copy (the one used today) to the state of this one with the following commands

git fetch origin
git reset --hard origin/mvd_online # !!!! WARNING: this will loose all local modifications to already committed files !!!!

changed the description

added 1 commit

c5a61e50 - add address scheme, handling mimosis raw data, modified CbmMvdRawDigi

Compare with previous version

added 1 commit

1b8b923d - [CI] fix online binary test due to extra MVD printout

Compare with previous version

Dear @d.smith, @fweig, @f.uhlig, @v.friese, @p.-a.loizeau, @c.muentz, @m.deveaux, @j.stroth,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

Hi @p.-a.loizeau,

I had look at the data from new unpacker class (which uses MimosisMessage and new CbmMvdRawDigi) and got some strange decoding of pixels. Which means there is bug in MimosisMessage class. I will have a look at this later but for the time being I go back to previous UnpackMS class but with new address scheme. I tested it and is working fine. I tried to commit my latest changes to this MR but I think I don´t have permission. So I will do same as before... I will create new MR to your branch... then you can commit these changes here. Or if you have any other suggestion, please let me know.

mentioned in merge request !1185 (closed)

added 1 commit

5eb42213 - go back to old UnpackMS class but with new address scheme

Compare with previous version

added 38 commits

5eb42213...268286ba - 30 commits from branch computing:master
3fdb9a36 - initial mMVD unpacker
a7cd0980 - added stuff for pulser analysis
9ab7a305 - Fix warnings in CbmMvdRawDigi
4f7ec5bc - Online: switch new setup from mMVD_Lab to mCBM2025_05
af81fc3f - Add missing mvd entry in online DigiEventQa
87d942b7 - add address scheme, handling mimosis raw data, modified CbmMvdRawDigi
c875492f - [CI] fix online binary test due to extra MVD printout
932f637d - go back to old UnpackMS class but with new address scheme

Compare with previous version

added 8 commits

a0b7d67e - [MVD] initial mMVD online unpacker
adab809c - [MVD] added stuff for pulser analysis with online unpacker
cd084857 - [MVD] Fix warnings in CbmMvdRawDigi
f6476a9f - Online: switch new setup from mMVD_Lab to mCBM2025_05
b67c6c42 - Add missing mvd entry in online DigiEventQa
cf256737 - [MVD] add address scheme, handling mimosis raw data, modified CbmMvdRawDigi
e1875594 - [CI] fix online binary test due to extra MVD printout
64efb5bc - [MVD] Online: go back to old UnpackMS class but with new address scheme

Compare with previous version

marked this merge request as ready

resolved all threads

TODO before merge:

Decide on conflict with !2118 (merged)
Depending on outcome of ^ discussion, merge CbmSoft/cbmroot_parameter!242 (merged) and add hash update

added 9 commits

ecd83d20 - 1 commit from branch computing:master
b3461300 - [MVD] initial mMVD online unpacker
6f264b4f - [MVD] added stuff for pulser analysis with online unpacker
54d36910 - [MVD] Fix warnings in CbmMvdRawDigi
a61b27d6 - Online: switch new setup from mMVD_Lab to mCBM2025_05
993d5495 - Add missing mvd entry in online DigiEventQa
7030464a - [MVD] add address scheme, handling mimosis raw data, modified CbmMvdRawDigi
3e570218 - [CI] fix online binary test due to extra MVD printout
d83776c7 - [MVD] Online: go back to old UnpackMS class but with new address scheme

Compare with previous version

mentioned in merge request !2163 (merged)

added mCBM label

mentioned in merge request !2175 (merged)

marked this merge request as draft

mentioned in merge request !2176 (merged)

added 69 commits

d83776c7...de3a7e21 - 62 commits from branch computing:master
b636045d - [MVD] initial mMVD online unpacker
61e3af47 - [MVD] added stuff for pulser analysis with online unpacker
e46785c1 - Online: switch new setup from mMVD_Lab to mCBM2025_05
f2c0a205 - Add missing mvd entry in online DigiEventQa
9bbda0ce - [MVD] add handling of mimosis raw data as classes
e40a0f3a - [MVD] Online: go back to old UnpackMS class but with new address scheme
50f9afb8 - [MVD] fix warnings in UnpackMs

Compare with previous version

@ajit.kumar Rebased version, compiles but untested on data

@v.friese @bartosz.sobol @s.zharko Keeping the MR in draft mode as I found out while checking the diffs that the parameters handling is missing (commented out in the Reco class and corresponding struct missing in the ReadoutConfig class). Not completely sure if this was just forgotten before or lost during the various rebase of the MR in the last 2 months.
As this anyway needs to be rewritten at least partially, I did not try to check the full history, this will need to be copied/adapted from !2098 (merged)

marked this merge request as ready

changed title from Draft: Mvd online unpack to Mvd online unpacker

added 8 commits

e6f99868 - 1 commit from branch computing:master
5cc322bb - [MVD] initial mMVD online unpacker
448e32d6 - [MVD] added stuff for pulser analysis with online unpacker
0d8722ed - Online: switch new setup from mMVD_Lab to mCBM2025_05
7bb0f76e - Add missing mvd entry in online DigiEventQa
7e0a8799 - [MVD] add handling of mimosis raw data as classes
ad5674e6 - [MVD] Online: go back to old UnpackMS class but with new address scheme
65775680 - [MVD] fix warnings in UnpackMs

Compare with previous version

added 3 commits

f218db6a - [MVD] add handling of mimosis raw data as classes
ddce3004 - [MVD] Online: go back to old UnpackMS class but with new address scheme
3ff80a9d - [MVD] fix warnings in UnpackMs

Compare with previous version

added 8 commits

3ff80a9d...643e9459 - 2 commits from branch computing:master
47c53387 - [MVD] initial mMVD online unpacker
2635c324 - [MVD] added stuff for pulser analysis with online unpacker
e751cb5a - Online: switch new setup from mMVD_Lab to mCBM2025_05
8e18d0b4 - [MVD] add handling of mimosis raw data as classes
afd13c40 - [MVD] Online: go back to old UnpackMS class but with new address scheme
f2de9956 - [MVD] fix warnings in UnpackMs

Compare with previous version

added 1 commit

e6d48027 - [MVD] fix warnings in UnpackMs

Compare with previous version

mentioned in merge request !2187 (merged)

added 23 commits

e6d48027...1a64878c - 16 commits from branch computing:master
a59bf675 - [MVD] initial mMVD online unpacker
f6620e67 - [MVD] added stuff for pulser analysis with online unpacker
0a14f993 - Online: switch new setup from mMVD_Lab to mCBM2025_05
f3610fa2 - [MVD] add handling of mimosis raw data as classes
55e4f01d - [MVD] Online: go back to old UnpackMS class but with new address scheme
61d460dc - [MVD] fix warnings in UnpackMs
4dcca662 - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible

Compare with previous version

added 1 commit

3db2946a - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible

Compare with previous version

added 1 commit

ac84e9b0 - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible

Compare with previous version

added 1 commit

c20fc88a - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible

Compare with previous version

added 8 commits

d4f35a96 - 1 commit from branch computing:master
d0be0d18 - [MVD] initial mMVD online unpacker
cfde941e - [MVD] added stuff for pulser analysis with online unpacker
aafb950a - Online: switch new setup from mMVD_Lab to mCBM2025_05
9c16cbf4 - [MVD] add handling of mimosis raw data as classes
22d937fe - [MVD] Online: go back to old UnpackMS class but with new address scheme
c7751470 - [MVD] fix warnings in UnpackMs
be68989f - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible

Compare with previous version

added 1 commit

09e1aa4b - Algo: Fixes in mvd unpack following Sergei review

Compare with previous version

added 10 commits

8366a70a - 1 commit from branch computing:master
69abc749 - [MVD] initial mMVD online unpacker
d5743b35 - [MVD] added stuff for pulser analysis with online unpacker
5fd7433c - Online: switch new setup from mMVD_Lab to mCBM2025_05
655fcc30 - [MVD] add handling of mimosis raw data as classes
5e869147 - [MVD] Online: go back to old UnpackMS class but with new address scheme
0110f687 - [MVD] fix warnings in UnpackMs
e381ded6 - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible
88a3cd3c - Algo: Fixes in mvd unpack following Sergei review
80193d5b - Algo: Add support for YAML config of MVD with hardcoded backup

Compare with previous version

@s.zharko @ajit.kumar I added a new commit which brings the support for a YAML configuration of the unpacker, which work at least in a technical way with the last version of CbmSoft/cbmroot_parameter!242 (merged)

I could not test it in details as I did not have a TSA file with MVD data under the hand, but I could check the following:

if the YAML file is not found, the existing hardcoded config is used instead (legacy mode + fresh run insurance) and the timeslices are processed
if it is found, it is loaded and the timeslices are processed, meaning that everything up to the call to DoUnpack is OK
The output on-screen is same apart from the on-liner when loading the config

I would say once this is tested to give the same output in both modes, this MR could be considered ready

added 1 commit

e7bf05b8 - Algo: Add support for YAML config of MVD with hardcoded backup

Compare with previous version

added 26 commits

e7bf05b8...472858d4 - 18 commits from branch computing:master
7d737656 - [MVD] initial mMVD online unpacker
f9800ba1 - [MVD] added stuff for pulser analysis with online unpacker
1e9f3218 - [MVD] add handling of mimosis raw data as classes
bfcf9848 - [MVD] Online: go back to old UnpackMS class but with new address scheme
6e1959fa - [MVD] fix warnings in UnpackMs
659eaf51 - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible
0af874d6 - Algo: Fixes in mvd unpack following Sergei review
a2ce2283 - Algo: Add support for YAML config of MVD with hardcoded backup

Compare with previous version

added 16 commits

a2ce2283...c4d25175 - 8 commits from branch computing:master
0809d0c0 - [MVD] initial mMVD online unpacker
8ed404e0 - [MVD] added stuff for pulser analysis with online unpacker
d1c40074 - [MVD] add handling of mimosis raw data as classes
d9cbef9f - [MVD] Online: go back to old UnpackMS class but with new address scheme
964789d7 - [MVD] fix warnings in UnpackMs
f756c5b2 - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible
5f2d81a5 - Algo: Fixes in mvd unpack following Sergei review
18a9d98b - Algo: Add support for YAML config of MVD with hardcoded backup

Compare with previous version

added 8 commits

f99813f5 - [MVD] initial mMVD online unpacker
735612b7 - [MVD] added stuff for pulser analysis with online unpacker
5133d5f8 - [MVD] add handling of mimosis raw data as classes
100b7f04 - [MVD] Online: go back to old UnpackMS class but with new address scheme
f4ad9246 - [MVD] fix warnings in UnpackMs
8b238fee - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible
e2939244 - Algo: Fixes in mvd unpack following Sergei review
cd54cd18 - Algo: Add support for YAML config of MVD with hardcoded backup

Compare with previous version

added 14 commits

cd54cd18...de046832 - 6 commits from branch computing:master
fb934345 - [MVD] initial mMVD online unpacker
574de3ed - [MVD] added stuff for pulser analysis with online unpacker
00cbac5c - [MVD] add handling of mimosis raw data as classes
54651e14 - [MVD] Online: go back to old UnpackMS class but with new address scheme
d74143ba - [MVD] fix warnings in UnpackMs
0abfd6d5 - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible
4e8c09f4 - Algo: Fixes in mvd unpack following Sergei review
eaa612f0 - Algo: Add support for YAML config of MVD with hardcoded backup

Compare with previous version

resolved all threads

Will merge as is for now and prepare a new branch in this Cbmroot project with developers allowed to merge and force-push where I will add a commit removing the hard-coded Init and missing/broken-YAML fallback (breaks a bit our workflow of individual forks, but then @ajit.kumar can modify it and take over).
=> This can then be used for further cleanup/optimization of the MVD ReadoutConfig class (or of the unpacker itself)

added 11 commits

eaa612f0...a71755e4 - 2 commits from branch computing:master
41d6da6d - [MVD] initial mMVD online unpacker
85b69017 - [MVD] added stuff for pulser analysis with online unpacker
f4890901 - [MVD] add handling of mimosis raw data as classes
30572a0e - [MVD] Online: go back to old UnpackMS class but with new address scheme
e8730e24 - [MVD] fix warnings in UnpackMs
30f9544a - [MVD] Unpack: compute frame nb from time + make RawDigi and Digi more compatible
26f76130 - Algo: Fixes in mvd unpack following Sergei review
59cbfa2e - Algo: Add support for YAML config of MVD with hardcoded backup
b4223660 - Bump params hash to bring the MVD unpacker YAMl files (+mCBM 2025/05 folders)

Compare with previous version

enabled an automatic merge when all merge checks for b4223660 pass

merged

mentioned in merge request !2207

mentioned in merge request !2208

changed the description

Mvd online unpacker

Merge request reports

Activity