Skip to content
Snippets Groups Projects

CbmUtility library

Open CbmUtility library
s.zharko/cbmroot:CbmUtility-lib into master
5 unresolved threads
Open Sergei Zharko requested to merge s.zharko/cbmroot:CbmUtility-lib into master
5 unresolved threads

The merge request creates a CbmUtility library in the core of CbmRoot. The library is supposed to contain extensions to STL and Boost C++ utilities.

NOTE: This should be merged after !2085.

Edited by Sergei Zharko

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/containers/CMakeLists.txt 0 → 100644
1 # Library: CbmContainers
2 #
3
4 message("!!!! BUILDING CbmContainers")
  • Florian Uhlig
    Florian Uhlig @f.uhlig started a thread on the diff
    • algo/base/yaml/CMakeLists.txt → core/utility/yaml/CMakeLists.txt
    1 1 set(INCLUDE_DIRECTORIES
    2 ${CMAKE_SOURCE_DIR}/algo/base # For "algo/base/yaml/*.h" included as relative "yaml/?????.h" to fit install tree
    2 ${CMAKE_CURRENT_SOURCE_DIR}/.. # For inclusions like "yaml/Yaml.h"
    • Florian Uhlig
      Florian Uhlig @f.uhlig ·
      Owner

      I am not sure if I like the relative path.

    • Sergei Zharko
      Sergei Zharko @s.zharko ·
      Author Maintainer

      For some reason only the relative path works for me. Otherwise it cannot find "yaml/Yaml.h" during building

    • Pierre-Alain Loizeau
      Pierre-Alain Loizeau @p.-a.loizeau ·
      Maintainer

      I think this is because either you tried to use ${CMAKE_CURRENT_SOURCE_DIR instead of ${CMAKE_SOURCE_DIR} or you forgot to update the partial path after moving he folder.
      As you moved the folder, please try with the following suggestion

      Suggested change
      2 ${CMAKE_CURRENT_SOURCE_DIR}/.. # For inclusions like "yaml/Yaml.h"
      2 ${CMAKE_SOURCE_DIR}/core/utility # For "algo/base/yaml/*.h" included as relative "yaml/?????.h" to fit install

      Second thought coming to me while writing this: even better would be to start using here the convention of "full path install and include for namespaced headers with generic names"
      So

      1. Installing all headers of this library under <install>/include/core/utility/yaml instead of <install>/include/yaml/
      2. Changing all includes to #define "core/utility/yaml/XXXXX.h"
      3. Changing this line to be only ${CMAKE_SOURCE_DIR} # Full path includes for this library
      Edited by Pierre-Alain Loizeau
    • Please register or sign in to reply
  • Florian Uhlig
    Florian Uhlig @f.uhlig started a thread on the diff
    • algo/online/containers/CMakeLists.txt 0 → 100644
    1 # Online version of libCbmContainers
  • Florian Uhlig
    Florian Uhlig @f.uhlig started a thread on the diff
    • algo/online/containers/CMakeLists.txt 0 → 100644
    1 # Online version of libCbmContainers
    2
    3 set(OFFLINE_CONTAINERS_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../../../core/containers)
  • Florian Uhlig
    Florian Uhlig @f.uhlig started a thread on the diff
    • algo/data/CMakeLists.txt → algo/online/data/CMakeLists.txt
    2 2 # the array .
    3 3 # The extension is already found. Any number of sources could be listed here.
    4 4
    5 set(OFFLINE_DATA_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../../core/data)
    Please register or sign in to reply