Norbert Herrmann authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Apply clang-format. uncomment TofSimpClusterizer constructor

Use std::string instead of TString to format log output.

Volker Friese authored 3 years ago and Florian Uhlig committed 3 years ago

Correct CbmDaq to provide the proper MC event list. Prevent tree access modes kRepeat and kRandom for the time being.

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Split the InitUnpacker method of the UnpackConfig template into
  - InitOutput
  - RegisterOutput (Framework bound, to be replaced by method in Task class CbmRecoUnpack)
  - SetAlgo
  - initParContainer, moved to the Task Class CbmRecoUnpack
  - InitAlgo
- Move to the template version of these methods all blocks common to all derived config classes
- Whenever necessary, overload these methods in the derived config classes (including the common parts, no base method call)
- Bump Config classes version number
- Adapt the Sts Unpack algo classes to initialize the monitor classes
- Adapt the CbmRecoUnpack
- Adapt the CbmUnpackDevice to use the standard Unpack Config classes (compiles with full functionality but untested)

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add all data classes needed by libAlgo to libOnlineData.
Add all other referenced classses to libOnlineData.
Remove ROOT dependencies from all these classes.

Link libAlgo against libOnlineData.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- Move implementation of CbmMuchAddress::SetElementId to cpp file
- Move Logger include from header to cpp
- Add missing Logger include to CbmMuchSignal cxx file
- Add missing Logger include to CbmAnaDimuonAnalysis cxx file (needed only for FS/FR jun19-v18.2)

Induced by inclusion in DigiData of the other detectors on top of STS (needed only for FS/FR higher than FS/FR jun19-v18.2)

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- Add copy constructor to CbmEvent
- Define DigiData types and add members for the other CBM detectors in CbmDigiData(!MUCH beamtime digi usage!)
- Add vector of CbmEvents, all DigiData types, CbmDigiEvent and vector of CbmDigiEvent to LinkDef to get ROOT streamers (needed to write to ROOT file)

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

In CbmMcbm2018RichPar, add explicit assignment OP constructor + replace map with vector when possible

- Introduce LoadInternalContainers method for setting all memberss derived from other members
- replace fToTshiftMap map with vector as continuous array with always successive keys (faster access)
- add the copy and assignment constructors
- Add a Print method

- Replace all legacy hard-coded numerical values for the TS_MSB cycle size by a constant derived in StsXyterMessage from the data format
- Remove deprecated special cases in the handling of the TS_MSB messages which are not present anymore in the current CRI data format
- Do not update TS_MSB and TS_MSB cycle from the MS header when the cycle happened exactly at the end of last MS
- Recompute the TS+MSB in TS offset from the MS heder only when changing the Cycle or the TS_MSB from the same header
- Add static method to convert Message Type into human readable string
- Slight improve/cleanup of debug printouts and debug levels

Was leading to errors and a crash in mCBM 2021 run 1588 files node8_3_0123 and node8_5_0002

Due to some missed casting to double values, the UTC time stored in the CbmTrdRawMessageSpadic lost precision.
Now we also only store the time relative to the Timeslice in the 2021+ unpacker, such that a double is large enough to store the full information.

Volker Friese authored 3 years ago and Florian Uhlig committed 3 years ago

Integration of cbm::algo::EventBuilder in the FairRoot run/task framework, with the new task CbmTaskBuildEvents. Included into regular testing. Refs #2271.

Volker Friese authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Enabled setting parameters for single STS ASICs. Expanded ASIC parameter container by time offset and coefficients for walk correction.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

There was a circular dependency between Littrack and CbmRichReco. The problem
only shows up when linking an executable.
The dependency could be resolved by moving some of the rich code into the
directory core/detectors/rich and splitting the littrack library into two parts.
The first library (Littrack) contains everything beside the littrack QA classes
and the second one (LittrackQA) contains only the QA code. Those files moved
from reco/detectors/rich had no dependencies to reco or sim.