Michael Deveaux authored 2 years ago and Florian Uhlig committed 1 year ago

First adaptations for a time based digitizer. Methods added but not used in CbmMvdDigitizerTask and CbmMvdDataSheet

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Update license header.
Use nullptr instead of macro NULL.
Remove path from include statements.
Add missing include statements and remove unneeded ones.
Use forward declaration whenever possible.
Remove obsolete functions.
Move cout to LOG.
Remove some unnecessary code.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Remove function SetProduceNoise from CbmMvdSensor and CbmMvdDetector. The
function from the plugin is now called directly from the digitizer.
Exchange some casts to the final taks by using the base class instead.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Add build system files for new mvd code structure
Move code from mvd directory to core/detectors/mvd, sim/detectors/mvd,
reco/detectors/mvd and analysis/detectors/mvd.
Create the libraries CbmMvdCore, CbmMvdSim, CbmMvdReco and CbmMvdAna.

This commit will not compile.

Vikas Singhal authored 1 year ago and Florian Uhlig committed 1 year ago

Earlier clang formatting didn't apply though (./scripts/check-apply-format-changes.sh apply) was executed

- CTest for running qa_compare.C macro
- Improvements in QA-Checker

Pierre-Alain Loizeau authored 1 year ago and Florian Uhlig committed 1 year ago

- cf https://github.com/root-project/root/issues/12242
- Fixes edge case of #2620 which was missed by previous patch: Assemblies which are not PhysicalNodes were not recomputed if not touched

- track type and track fit histogrammers added
- index bug in TimeSliceReader class fixed

With FairRoot v18.8 the functions GetOutputFile() and SetOutputFile() are
deprecated instead of using a file sink. Correct user code to create the
file sink correctly or to extract the file name from the file sink.
Comparisons of results before and after the change showed that the results
are absolutely identical.

The function sprintf is marked deprecated with the latest Clang version.
Move from sprintf to snprintf. Define and use buffer size.
Check the return value in a function where this is important.

Pierre-Alain Loizeau authored 2 years ago and Florian Uhlig committed 2 years ago

Solves original scope of #2567

Alexandru Bercuci authored 2 years ago and Florian Uhlig committed 2 years ago

sets and to take into account the alignment

The operator needs to exclude a gap in the sequence of numbers. Unfortunately
this was done wrongly such that adding new entries in the enum were also
excluded.