Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

The target is not available in newer FairMQ versions.

Use the same target names as provided by FairRoot with version v18.8.

Add the new target FairRoot::Online which is a new library conatining the
online related code which was previously part of the Base library.
In case of older FairRoot versions the target is only an alias for the target
FairRoot::Base such that the same dependencies already work with FairRoot
v18.6 which is our current default version.

Add the new target FairRoot::Online in all CMakeLists.txt where it is needed.

The FindFairRoot macro is also used when compiling NicaFemto. Since there is a
problem with the target definitions in NicaFemto the targets are not defined
when compiling NicaFemto.

CMakeList.txt files are modified according to modern CMake.
generate_cbm_executable() macro is used to make executable.
Imported targets of each package are used as dependencies.

Linking the MQ TSA  binaries on Debian11 need an additional boost library as
well as a reordering of the link libraries.

=> needed to collect histo and canvases from multiple instances of the devices (e.g. multiple nodes) in a single histo server
=> Same cannot easily be in processing classes like Unpack and BuildEvent as both name and folder need to be changed to avoid collisions

- Add BMon Unpack/Monitor device
- Add possibility to request from the source the start time of the first TS

Jan de Cuveland authored 2 years ago and Administrator committed 2 years ago

- fles_ipc -> external::fles_ipc
- fles_logging -> external::fles_logging
- IPC_INCLUDE_DIRECTORY -> FLES_IPC_INCLUDE_DIRECTORY

Fix deprecation warnings about upercase log levels. Use lowercase ones.

- Make sure that Histo servers gets the right number of parts even if no histos/no canvases to configure or send
- Do not send STOP command after EOF in CbmMQTsSamplerRepReq
- Pre-book capacity in typical range for input vectors in DigiEventBuilder device

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

The templated functions Deserialize and Serialize of the FairMQ Device are
marked deprecated. These templates acctually only forward the call to the
BoostSerializer and RootSerializer classes which are part of FairRoot.
Call these classes directly to remove deprectaion warnings.

The cleanup of the shared memory wasn't working anymore. The executable is
a part of FairMQ which was moved from FairRoot in its own package. Also the
name of the excutable has changed to fairmq-shmmonitor which is now installed
in SIMPATH.

Remove blank characters from the end of lines.

Create MQ startup scripts to be installed already at the configuration stage
and store the in the build tree. The difference between the scripts used in
the build tree and the scripts finally installed are the hardcoded directory
information inside. In the scripts to be used inside the build directory this
links to the source and the build directories whereas it links to the
installation directory in case of the scripts which are installed.
Copy the scripts during installation to the correct directory.
Install the MQ executables in the same directory structure as in the build
directory.

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Switch Sampler-Unpackers connection from Push-Pull to Rep-Req! lower sample memory usage and better load-balancing performances (first ready first served)!
- Use single channel for all histograms exchanges (objects but also configs)... to be cross-checked as some warnings
- In CbmMQTsSamplerRepReq, fix logic for emission of missing TS list when first missing is index 1
- In CbmMQTsSamplerRepReq, add case of missing TS 0 to same logic (starting processing after beginning of a run)
- In CbmMQTsSamplerRepReq, fix the stop execution when reaching max TS nb condition

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Add CbmDeviceDigiEventSink class and DigiEventSink binary
- In TsaMultiSampler, fix logic for emission of missing TS list when first missing is index 1
- Use vector ofCbmEvents instead of TClonesArray at output of BuildDigiEvents
- Add missing features file for Unpack-Build-Sink chain
- Add optional output of the full digi vectors in Event Sink

=> Tested with first file of run 1588, missing TS probably need better handling as too many empty fields

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Remove wrong license header drom several files which came in by using a
template. The code was developed by the respective persons, the license header
came in by using a skeleton.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

It was advised by the FariMQ expert to switch from a push-pull approach to a Rep-Req one.
This should improve the balance of TS delivery when they have non uniform size/processing time
and reduce the buffering in the Sample
- Add new sampler class CbmMQTsSamplerRepReq using the reply model
- Add example of a consummer device using the request model
- Add new monitor classes for T0 and TOF using the request model

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

[FLES IPC] In Multi-part subscriber, move the init out of the constructor to follow FairMQ states design
- Temporary patch to fles IPC external files
- Corresponding modifications in CbmMQTsaMultiSampler
- Corresponding modifications in CbmMcbm2018Source

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- In both, add InitHistograms method
- Call InitContainers and InitHistograms in Run and only on first message

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

The class FairLogger is  meanwhile only a wrapper around the Logger class,
so use the Logger directly. This also helps to reduce many warnings when
using the Eclipse IDE.

Administrator authored 4 years ago and Florian Uhlig committed 4 years ago

Use reference in for loop too avoid copying of data.

Add support for C++17
Check for c++ version c++11 or above (11, 14 or 17). With this change it
becomes possible to compile CbmRoot with C++17.

Add missing library.
The FairMQ state machine is now in an extra library which has to be added
for linking when using FairSoft nov20. Test if the library exist and create
the list of dependencies accordingly.

Add missing include directory.
VMC is not any longer included in ROOT but a standealone package, so the
include directory has to be added such that the header files are found.

Add gtest as an optional external package.
With the latest version of FairSoft googletest was removed due to a
recommendation of the gtest developers. Since gtest is no longer part of
FairSoft we have to provide an own version which is compiled as external
project.

Add proper dependency to external gtest project
This dependency is needed to compile the test only if the gtest library is
already available.

Fix compilation error with FairRoot v18.4.2 on macosx
In FairRoot v18.4.2 some linker settings were removed from the CMake setup.
This breaks the compilation of CbmRoot. Put back the needed seetings for the
linker on macosx in our build system.

Fix NicaFemto installation

Apply code formatting to all source/header files and root macros.

MQ: in TsaMultiSampler source class, add optional support for emission of a missed TS indices list and EOF command + prepare histos support

Remove the ecal directory and the directory with the ecal data classes.
Adapt the build system accordingly. Closes #1756 @0.5h