Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

=> needed to collect histo and canvases from multiple instances of the devices (e.g. multiple nodes) in a single histo server
=> Same cannot easily be in processing classes like Unpack and BuildEvent as both name and folder need to be changed to avoid collisions

    - Fix to the performance plots of the DigiEventSink by changing the logic to Profile or new counts addition
    - Add option for DigiEvent I/O between builders and Sink

- Evolution of the full TS buffer size as function of device runtime
- Evolution of the missed TS buffer size as function of device runtime
- Evolution of the Processed full TS count as function of device runtime
- Evolution of the Processed missing TS count as function of device runtime
- Evolution of the Total processed TS count as function of device runtime
- Evolution of the Processed events count as function of device runtime

[MQ] in DigiEventSink, add flag to control Missing TS empty writing if consecutive check is ON, false by default

- The check for consecutive TS indices was still called when receiving Missing TS Data messages even if the bypass flag was set
  => Surround the call with proper if condition
- The range when taking the digis data out of the unpacked timeslice to the DigiEvent was missing the last digi for all detectors
  => Increment the stop iterator to make sure it is included
- In rare case, the device can be pulled down before the Init method is called/finished, which led to a segfault
  => add an InitDone flag + use it to control delete operations in the destructor

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Switch Sampler-Unpackers connection from Push-Pull to Rep-Req! lower sample memory usage and better load-balancing performances (first ready first served)!
- Use single channel for all histograms exchanges (objects but also configs)... to be cross-checked as some warnings
- In CbmMQTsSamplerRepReq, fix logic for emission of missing TS list when first missing is index 1
- In CbmMQTsSamplerRepReq, add case of missing TS 0 to same logic (starting processing after beginning of a run)
- In CbmMQTsSamplerRepReq, fix the stop execution when reaching max TS nb condition

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Add CbmDeviceDigiEventSink class and DigiEventSink binary
- In TsaMultiSampler, fix logic for emission of missing TS list when first missing is index 1
- Use vector ofCbmEvents instead of TClonesArray at output of BuildDigiEvents
- Add missing features file for Unpack-Build-Sink chain
- Add optional output of the full digi vectors in Event Sink

=> Tested with first file of run 1588, missing TS probably need better handling as too many empty fields

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

Administrator authored 4 years ago and Florian Uhlig committed 4 years ago

Cleanup filtering of compiler warnings for Nightly tests

Remove unused variables, parameters and data members.
Remove move statement to allow copy ellision.
Use unsingned int in loop when comparing with size function of containers.
Initialize all data members.

Fix warning from rootcling.
With newer root versions the parameter -c isn't supported any longer,
so remove it.

Pierre-Alain Loizeau authored 4 years ago and Volker Friese committed 4 years ago

Fixes in mCBM 2020 Algos and MQ examples:
- Remove JSROOT commands fore reset/save histos in MQ histos server and devices, as not working (need cling context!).
- Add/extend support for T0 channels remapping + related plots.
- Fix TOF pulser algo (logic was broken before and chain resetting the output plots).
Add macro folder + MQ monitor scripts for TOF and T0.

Apply code formatting to all source/header files and root macros.

- Unpacker device running an instance of the unpacker algo of each of the participating detectors
- Event builder device running an instance of CbmMcbm2019TimeWinEventBuilderAlgo
- Event Sink acting as a parrallel stream aligner and merger + as a disk sink
- Start script for a chain with a single MultiTsa source, parallel branches of Unpacker + EventBuilder, a single EventSink and an histogram server
- Pulser monitor device (untested)