Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Add CbmDeviceDigiEventSink class and DigiEventSink binary
- In TsaMultiSampler, fix logic for emission of missing TS list when first missing is index 1
- Use vector ofCbmEvents instead of TClonesArray at output of BuildDigiEvents
- Add missing features file for Unpack-Build-Sink chain
- Add optional output of the full digi vectors in Event Sink

=> Tested with first file of run 1588, missing TS probably need better handling as too many empty fields

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Device using the central event builder algo in reco, with compatibility to output of the new unpack device
- Macro using these two new devices and setting the parameter files for the mCBM July 2021 data (optimized for run 1588)

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Split the InitUnpacker method of the UnpackConfig template into
  - InitOutput
  - RegisterOutput (Framework bound, to be replaced by method in Task class CbmRecoUnpack)
  - SetAlgo
  - initParContainer, moved to the Task Class CbmRecoUnpack
  - InitAlgo
- Move to the template version of these methods all blocks common to all derived config classes
- Whenever necessary, overload these methods in the derived config classes (including the common parts, no base method call)
- Bump Config classes version number
- Adapt the Sts Unpack algo classes to initialize the monitor classes
- Adapt the CbmRecoUnpack
- Adapt the CbmUnpackDevice to use the standard Unpack Config classes (compiles with full functionality but untested)

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Remove wrong license header drom several files which came in by using a
template. The code was developed by the respective persons, the license header
came in by using a skeleton.

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

Unify user names in the license header authors list.
Remove duplicate users in the authors list.
Cleanupo of some other inor issues.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

The class FairLogger is  meanwhile only a wrapper around the Logger class,
so use the Logger directly. This also helps to reduce many warnings when
using the Eclipse IDE.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The current flesnet version contain all changes/patches which we did so far
when compiling CbmRoot.
The new flesnet version also needs un updated version of cppzmq.
refs. #2068, #2069

Administrator authored 4 years ago and Florian Uhlig committed 4 years ago

Cleanup filtering of compiler warnings for Nightly tests

Remove unused variables, parameters and data members.
Remove move statement to allow copy ellision.
Use unsingned int in loop when comparing with size function of containers.
Initialize all data members.

Fix warning from rootcling.
With newer root versions the parameter -c isn't supported any longer,
so remove it.

Pierre-Alain Loizeau authored 4 years ago and Volker Friese committed 4 years ago

Fixes in mCBM 2020 Algos and MQ examples:
- Remove JSROOT commands fore reset/save histos in MQ histos server and devices, as not working (need cling context!).
- Add/extend support for T0 channels remapping + related plots.
- Fix TOF pulser algo (logic was broken before and chain resetting the output plots).
Add macro folder + MQ monitor scripts for TOF and T0.

Add support for C++17
Check for c++ version c++11 or above (11, 14 or 17). With this change it
becomes possible to compile CbmRoot with C++17.

Add missing library.
The FairMQ state machine is now in an extra library which has to be added
for linking when using FairSoft nov20. Test if the library exist and create
the list of dependencies accordingly.

Add missing include directory.
VMC is not any longer included in ROOT but a standealone package, so the
include directory has to be added such that the header files are found.

Add gtest as an optional external package.
With the latest version of FairSoft googletest was removed due to a
recommendation of the gtest developers. Since gtest is no longer part of
FairSoft we have to provide an own version which is compiled as external
project.

Add proper dependency to external gtest project
This dependency is needed to compile the test only if the gtest library is
already available.

Fix compilation error with FairRoot v18.4.2 on macosx
In FairRoot v18.4.2 some linker settings were removed from the CMake setup.
This breaks the compilation of CbmRoot. Put back the needed seetings for the
linker on macosx in our build system.

Fix NicaFemto installation

- Add predefined EventBuilderDetector constants for each of the typical detectors
- Add interface methods taking EventBuilderDetector object as parameter
- Make all other interface methods use the EventBuilderDetector one
- Mark the methods using only ECbmModuleId as deprecated
- Update MQ device accordingly
- Disable clang-formatting in Init method of MQ device

Apply code formatting to all source/header files and root macros.

- Unpacker device running an instance of the unpacker algo of each of the participating detectors
- Event builder device running an instance of CbmMcbm2019TimeWinEventBuilderAlgo
- Event Sink acting as a parrallel stream aligner and merger + as a disk sink
- Start script for a chain with a single MultiTsa source, parallel branches of Unpacker + EventBuilder, a single EventSink and an histogram server
- Pulser monitor device (untested)