Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Add CbmDeviceDigiEventSink class and DigiEventSink binary
- In TsaMultiSampler, fix logic for emission of missing TS list when first missing is index 1
- Use vector ofCbmEvents instead of TClonesArray at output of BuildDigiEvents
- Add missing features file for Unpack-Build-Sink chain
- Add optional output of the full digi vectors in Event Sink

=> Tested with first file of run 1588, missing TS probably need better handling as too many empty fields

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Device using the central event builder algo in reco, with compatibility to output of the new unpack device
- Macro using these two new devices and setting the parameter files for the mCBM July 2021 data (optimized for run 1588)

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Split the InitUnpacker method of the UnpackConfig template into
  - InitOutput
  - RegisterOutput (Framework bound, to be replaced by method in Task class CbmRecoUnpack)
  - SetAlgo
  - initParContainer, moved to the Task Class CbmRecoUnpack
  - InitAlgo
- Move to the template version of these methods all blocks common to all derived config classes
- Whenever necessary, overload these methods in the derived config classes (including the common parts, no base method call)
- Bump Config classes version number
- Adapt the Sts Unpack algo classes to initialize the monitor classes
- Adapt the CbmRecoUnpack
- Adapt the CbmUnpackDevice to use the standard Unpack Config classes (compiles with full functionality but untested)

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Remove wrong license header drom several files which came in by using a
template. The code was developed by the respective persons, the license header
came in by using a skeleton.

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Comment unused variables and data members.
Fix printf formating issue which is different between macosx and Linux.

A static const class member in a cout statement results in an undefined symbol
when linking an executable using the class.
The solution is to do a static cast of the variable in the cout statement.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

It was advised by the FariMQ expert to switch from a push-pull approach to a Rep-Req one.
This should improve the balance of TS delivery when they have non uniform size/processing time
and reduce the buffering in the Sample
- Add new sampler class CbmMQTsSamplerRepReq using the reply model
- Add example of a consummer device using the request model
- Add new monitor classes for T0 and TOF using the request model

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

[FLES IPC] In Multi-part subscriber, move the init out of the constructor to follow FairMQ states design
- Temporary patch to fles IPC external files
- Corresponding modifications in CbmMQTsaMultiSampler
- Corresponding modifications in CbmMcbm2018Source

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- In CbmMqHistoServer, add a new method processing a multi-part message to combine Histo config, Canvas config and histo data
- Attach this new method to the histo data input channel
- Convert the T0 MQ monitor to this single channel usage
- Convert the Tof MQ monitor to this single channel usage

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- In both, add InitHistograms method
- Call InitContainers and InitHistograms in Run and only on first message

Unify user names in the license header authors list.
Remove duplicate users in the authors list.
Cleanupo of some other inor issues.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Inserts the declaration on the 1st or 2nd line of scripts.

EMPTY LINE

Short license declarations for .sh files

Inserts the declaration on the 1st or 2nd line of scripts.

EMPTY LINE

Revert "Short license declarations for .sh files"

This reverts commit d3dd8608.

Uses SPDX identifier

Modifies declaration to use SPDX license identifier syntax

Corrects file

Empty line before hashbang removed

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

The class FairLogger is  meanwhile only a wrapper around the Logger class,
so use the Logger directly. This also helps to reduce many warnings when
using the Eclipse IDE.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The current flesnet version contain all changes/patches which we did so far
when compiling CbmRoot.
The new flesnet version also needs un updated version of cppzmq.
refs. #2068, #2069

- Add threshold for non pulser digis in both algo, Task and device
- Make interval for spill threshold checks configurable in both algo, Task and device
- Spill detection only when both threshold passed
- Add Monitor macro for mCBM 2021 using this functionality

Remove check for ZeroMQ.
ZeroMQ isn't needed any longer.

Fix installation of externals when using Spack.
Pass extra flags flags to NicaFemto configuration if needed.
Patch ipc source code. Add missing include file.
Cleanup .gitignore in externals.

Fix linking of CbmGlobalTraking library.
Add missing link directory. In normal installation Vc probably was found in the
ROOT installation. With Spack ROOT is build without builtin Vc.

Use correct syntax for function call.
With the latest FairMQ version the old backward compatibility layer was
removed. Use now the new syntax to change the state.

Administrator authored 4 years ago and Florian Uhlig committed 4 years ago

Cleanup filtering of compiler warnings for Nightly tests

Remove unused variables, parameters and data members.
Remove move statement to allow copy ellision.
Use unsingned int in loop when comparing with size function of containers.
Initialize all data members.

Fix warning from rootcling.
With newer root versions the parameter -c isn't supported any longer,
so remove it.