Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

With the upcoming FairRoot release the function FillEventHeader of the
FairRootManager is deprecated, so use the function from FairSource directly.
Fixes #2644.

CMakeList.txt files are modified according to modern CMake.
generate_cbm_executable() macro is used to make executable.
Imported targets of each package are used as dependencies.

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

=> needed to collect histo and canvases from multiple instances of the devices (e.g. multiple nodes) in a single histo server
=> Same cannot easily be in processing classes like Unpack and BuildEvent as both name and folder need to be changed to avoid collisions

    - Fix to the performance plots of the DigiEventSink by changing the logic to Profile or new counts addition
    - Add option for DigiEvent I/O between builders and Sink

- Evolution of the full TS buffer size as function of device runtime
- Evolution of the missed TS buffer size as function of device runtime
- Evolution of the Processed full TS count as function of device runtime
- Evolution of the Processed missing TS count as function of device runtime
- Evolution of the Total processed TS count as function of device runtime
- Evolution of the Processed events count as function of device runtime

[MQ] in DigiEventSink, add flag to control Missing TS empty writing if consecutive check is ON, false by default

- The check for consecutive TS indices was still called when receiving Missing TS Data messages even if the bypass flag was set
  => Surround the call with proper if condition
- The range when taking the digis data out of the unpacked timeslice to the DigiEvent was missing the last digi for all detectors
  => Increment the stop iterator to make sure it is included
- In rare case, the device can be pulled down before the Init method is called/finished, which led to a segfault
  => add an InitDone flag + use it to control delete operations in the destructor

- Bring in new mapping setter from 819c026f
- More Default time offsets values based on RunId, Nickel ones are relative to BMon instead of TOF

- Add option to skip the emission of the built events (and unpacked TS) on the ZMQ output
- Fix wrong type for the MaxNb parameter (signed as default is -1)
- Fix potential segfaults in destructor

- Add BMon Unpack/Monitor device
- Add possibility to request from the source the start time of the first TS

Jan de Cuveland authored 2 years ago and Administrator committed 2 years ago

- fles_ipc -> external::fles_ipc
- fles_logging -> external::fles_logging
- IPC_INCLUDE_DIRECTORY -> FLES_IPC_INCLUDE_DIRECTORY

[MQ] In startBuildRawEvents2022.sh, various improvement + add Add selection with min nb of fired TOF RPC

- allow setting the minimum number of fired layers for TOF
- allow using trigger parameter sets as arguments, matching the one of the NH version
- always require the run ID as argument
- have time offsets matching those of the NH version

[mTOF,mBmon] In unpack macro and device, prepare support for different mTOF maps for C, Fe and Ur files

- Improve the string to system conversion for the parameters in CbmDeviceBuildDigiEvents
- Add support for the min number of fired layers parameter in CbmDeviceBuildDigiEvents and runBuildDigiEvents

- Add proper Bmon support to unpack + build digi events chain
- Add proper Much support to unpack + build digi events chain
- Add user parameter + flags to CbmDeviceUnpack to enable/disable the unpacking of each detector
- Add proper handling of disabled detectors in MQ transfer ib both CbmDeviceUnpack and CbmDeviceBuildDigiEvents
- Add parameter to set "MaxNb" type selection in CbmDeviceBuildDigiEvents
- Synchronize unpackers configuration in CbmDeviceUnpack with the one in the current `macro/run/run_unpack_tsa.C`
- Use fles::SubsystemIdentifier instead of hard coded values in CbmDeviceUnpack

- Add optional method to resort indicices to the CbmEvent class, as the indices for TRD1D and 2D are added in separate steps
- Replace the loop over the CbmEvent indices by a block copy between the first and last digi of each detector type, based
  on the assumption that we use a time-window based selection on a sorted array, therfore leading to a continuous block
  => this is known to potentially copy more digis in the TRD case due to the eventual =/= windows and offsets for 1D and 2D

- Make sure that Histo servers gets the right number of parts even if no histos/no canvases to configure or send
- Do not send STOP command after EOF in CbmMQTsSamplerRepReq
- Pre-book capacity in typical range for input vectors in DigiEventBuilder device

Administrator authored 2 years ago and Volker Friese committed 2 years ago

Remove many switches which are not needed any longer, since minimum versions
for C++ standard, Root, FairSoft and FairRoot are fixed.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

The templated functions Deserialize and Serialize of the FairMQ Device are
marked deprecated. These templates acctually only forward the call to the
BoostSerializer and RootSerializer classes which are part of FairRoot.
Call these classes directly to remove deprectaion warnings.

Config class to align to the naming convention of Cbm and also decouple
FEE from read-out design

Use @VMCWORKDIR@ instaed which is exchanged by the acctual value while running
CMake. In case of $VMCWORKDIR/build uses @CMAKE_BINARY_DIR@.

Create MQ startup scripts to be installed already at the configuration stage
and store the in the build tree. The difference between the scripts used in
the build tree and the scripts finally installed are the hardcoded directory
information inside. In the scripts to be used inside the build directory this
links to the source and the build directories whereas it links to the
installation directory in case of the scripts which are installed.
Copy the scripts during installation to the correct directory.
Install the MQ executables in the same directory structure as in the build
directory.