- New option in RecoUnpack
- New queries creations if enabled
- Corresponding changes to CMake settings
* JSON file for one example Grafana dashboard
- HowTo file with installation and operation instructions

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

- Prevent FairrootManager from touching the source object trhogh its pointer after the run is over
- Explicitely delete the dynamically allocated Run and Source objects in the macro (give up share ownership of config objects)
- Give up ownership of the config objects, which triggers their destruction before reaching end of the macro (last owner of shared pointer)

Problem was that the FairrootManager was never going out of scope and was not calling the Source destructor.
So all shared pointers and the source objects were destroyed only when going out of scope in the ROOT session, at which time ROOT already deleted some TF1's, THx's and Canvases without asking anybody (global Lists).
The source and config destructors were then calling destructors for their members and member's members, where we tried to cleanup the memory we assigned but which ROOT already deleted.

- Cpu/Real time for processing and histogram filling
- Expansion ratio, input share and output share per TS for each system
- Global Expansion ratio (in size) per TS

- Change masking in Algo from full address to detector type
- Due to this, introduce in Algo implementation file a templated function to get the type if TofDigi or 0 instead
- Add support for using T0 as reference even if stored in TOF data (only in Algo, not in Task!)
- Add support for using T0 as trigger check detector even if stored in TOF data (only in Algo, not in Task!)
- Replace hard-coded constant in Algo with members + setters in both Algo and Task

Jan de Cuveland authored 2 years ago and Administrator committed 2 years ago

- fles_ipc -> external::fles_ipc
- fles_logging -> external::fles_logging
- IPC_INCLUDE_DIRECTORY -> FLES_IPC_INCLUDE_DIRECTORY

+ fix histo name in RecoUnpack

Vikas Singhal authored 3 years ago and Pierre-Alain Loizeau committed 2 years ago

- Add MUCH unpacker algo/config and monitoring classes in the current scheme
- Add new unpacking parameter class
* Separate the parameter files for the 2022 monitor and the 2022 unpacking
- Add MUCH in RecoUnpack
- Add MUCH in run_unpack_tsa and run_unpack_online macros

- Update Mcbm2018TofPar to map the 2022 BMon diamond
- Update Mcbm2018TofPar to map the new TOF modules for the 2022 iron beams (run 2100 onward)
- Add a BmonUnpackConfig class setting up the TOF unpacker to BMon mode
- Add a TofUnpackMonitor class providing monitoring plots for TOF and BMon unpacking
- Integrate this one in the TOF unpack algo
- Fix incomplete switching for the 2021 epoch hack in the TOF unpack Algo
- Add Bmon in the sterring RecoUnpack task
- Add a monitoring only mode to the RecoUnpack task were data is neither time sorted nor written to disk
- Add BMon in the unpacking macros
- Add the TOF monitor(s) to the unpacking macros
- Add BMon only unpacking macros for fast beam monitoring (especially for beam tuning)
- Add parameter files for TOF and BMon in the 2022 campaign

Config class to align to the naming convention of Cbm and also decouple
FEE from read-out design

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

- Split the InitUnpacker method of the UnpackConfig template into
  - InitOutput
  - RegisterOutput (Framework bound, to be replaced by method in Task class CbmRecoUnpack)
  - SetAlgo
  - initParContainer, moved to the Task Class CbmRecoUnpack
  - InitAlgo
- Move to the template version of these methods all blocks common to all derived config classes
- Whenever necessary, overload these methods in the derived config classes (including the common parts, no base method call)
- Bump Config classes version number
- Adapt the Sts Unpack algo classes to initialize the monitor classes
- Adapt the CbmRecoUnpack
- Adapt the CbmUnpackDevice to use the standard Unpack Config classes (compiles with full functionality but untested)

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add missing library dependencies and link directories.
Remove obsolete library dependencies and include/link directories.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Fix license headers in the last sub directories (base, eventbuilder and steer)
of the reco directory.
Add missing license headers.
Add commiter if missing.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- Add vector constructor to CbmSourceTsArchive
- Call string constructor of FLES IPC TimesliceAutoSource if vector of size 1
- Make vector input default in run_unpack macro
- Add alternative call with single string to run_unpack_macro to keep legacy interface available

Pierre-Alain Loizeau authored 3 years ago and Volker Friese committed 3 years ago

- Add Binning FW support to the Print method of the StsXyterMessage, enabled by default
- Fix the duplicate digis filtering in the STS unpacker and make it flag controllable
- Add an optional full time sorting to the Unpackers steering class
- Related mCBM macros changes

Jan de Cuveland authored 3 years ago and Florian Uhlig committed 3 years ago

This change corresponds to Pascal's request at
computing/cbmroot!455 (comment 13399)

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

Before this fix only the number of digis of the last component of a subsystem endet up in the counter of the event header. Now an Add function is used and the counters a resetted at the beginning of each timeslice.

Pascal Raisig authored 3 years ago and Florian Uhlig committed 3 years ago

This commit adds the measurement of the cpu and wall time to the unpacking algo template/CbmRecoUnpack::unpack function.
The values are printed add the end of the run and stored additionally in an output histogram.

It was not checked if a Trd1D config exists before trying to get its main branch name. This caused a seg violation in case no Trd1D config was added. Now the safeties are adjusted to check for it.
Includes a minor update of the naming scheme

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Since, the FairSource::Source_Type setting changes the behavior on the reading of the first Timeslice, its usage is for the time being removed. Therefore, a CbmSourceType enum is introduced which handles now the switch between data reading from online and offline sources.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Remove by hand added CbmTsEventHeader from CbmRecoUnpack. Instead, use the getter from the FairRun::Instance() to access the event header. Remark a fatal will be created if the wrong event header is set in the steering macro

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Switch form info to log for debug log statement

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Changed severity for large amount of LOG statements

Changed default from info to debug for a larger amount of tof log messages. Otherwise, it makes info reading with all subsystems almost impossible.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Unfortunately this does not yet produce digis, but I am note sure, if it is an parameter based issue or an issue with the implementation. I think it needs some experts from the Sts to have a look. Which is why I am pushing it.