Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

Semen Lebedev authored 2 years ago and Florian Uhlig committed 2 years ago

* RICH QA code updates
* Updates of run macros and scripts
* Remove obsolete macro from rich macro directories
* Updates in RICH event display

Cornelius Feier-Riesen authored 3 years ago and Florian Uhlig committed 2 years ago

add new PLUTO path (Tetyanas folder)
add purity histograms
add histograms to investigate diff. between PLUTO/UrQMD and electron/positron
add CB histograms in LmvmDraw.cxx
add histogram to investigate BG and its sources
add histosgrams for acc and rec. pions and electrons for var. detector
combinations
some more small changes

Fix deprecation warnings about upercase log levels. Use lowercase ones.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add missing library dependencies and link directories.
Remove obsolete library dependencies and include/link directories.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The implementation of the function was in the source file. Since the
function was also used in a qa class no code code be created at that
place. This results in a missing symbol during linking.
Put the template code properly in the header solves the problem.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

There was a circular dependency between Littrack and CbmRichReco. The problem
only shows up when linking an executable.
The dependency could be resolved by moving some of the rich code into the
directory core/detectors/rich and splitting the littrack library into two parts.
The first library (Littrack) contains everything beside the littrack QA classes
and the second one (LittrackQA) contains only the QA code. Those files moved
from reco/detectors/rich had no dependencies to reco or sim.

In case of two institutes in the copyright statement add both cities.
Add commiter if missing.

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

Develop combinatorial BG procedure and add corresponding histograms

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Work around an issue in boost.
https://github.com/boostorg/property_tree/pull/50

Unify user names in the license header authors list.
Remove duplicate users in the authors list.
Cleanupo of some other inor issues.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

Fix missing registration of TofTracks to CbmEvent in littrack, needed for track length calculation. Refs #2112.

Add missing include statements.
With FairSoft apr21 and/or FairRoot v18.6.2 some implicitly included
header files aren't found any longer. Add include statements for these
header files explicitly.

The class FairLogger is  meanwhile only a wrapper around the Logger class,
so use the Logger directly. This also helps to reduce many warnings when
using the Eclipse IDE.

When installing CbmRoot using FairRoot v18.4 and FairSoft there was a problem
with the location of header files when executing macros. Some of the header
files couldn't be found which for some of them worked with printing warning
or error messages only. For other header files the macros simply crashed with
error messages about not found header files. It is unclear if this is a
FairRoot or Root issue but I would guess it is a Root problem.
The issue was solved by simply removing the path from the header file name when
generating the Root dictionary. In this case it is enough to specify the
directory where all header files are installed when running Root using the
environment variable ROOT_INCLUDE_PATH.

In some of the build system files missing directories where added such that
the dictionaries could be produced properly.