Administrator authored 1 year ago and Florian Uhlig committed 1 year ago

Remove all usage of cout.
Use the FairLogger instead.
Fix copyright statement.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Update license header.
Use nullptr instead of macro NULL.
Remove path from include statements.
Add missing include statements and remove unneeded ones.
Use forward declaration whenever possible.
Remove obsolete functions.
Move cout to LOG.
Remove some unnecessary code.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Add build system files for new mvd code structure
Move code from mvd directory to core/detectors/mvd, sim/detectors/mvd,
reco/detectors/mvd and analysis/detectors/mvd.
Create the libraries CbmMvdCore, CbmMvdSim, CbmMvdReco and CbmMvdAna.

This commit will not compile.

With FairRoot v18.8 the functions GetOutputFile() and SetOutputFile() are
deprecated instead of using a file sink. Correct user code to create the
file sink correctly or to extract the file name from the file sink.
Comparisons of results before and after the change showed that the results
are absolutely identical.

Frederic Julian Linz authored 2 years ago and Florian Uhlig committed 2 years ago

Check cbm_header init before using it.
Added runtime error for MCEventList.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

With the change to the CMake targets the dependency tree was broken. The
generation of the ROOT dictionary is now a target on its own which did not
depend on anything except the header files needed for the specific library.
Some of these header files include other header files from the external
libraries. The problem was that now it became possible that the dictionary
generation started before the external header files were available.

Add explicit dependencies from these dictionaries to the external libraries.

Omveer Singh authored 2 years ago and Florian Uhlig committed 2 years ago

    CMakeList.txt files are modified according to modern CMake.
    generate_cbm_library() macro is used to make target.
    Imported targets of each package are used as dependencies.

When compiling one of the test macros the compilation crashed. The reson was
a problem with the generated dictionary. The problem could be solved by
removing an include statement from the header file.

Warnings from included header files which are outside of the scope of our code
base are not interesting when building CbmRoot. Definde those external include
directories as system include directories such that the compiler hide those
warnings automatically.

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Remove obsolete, unneeded and unused code.

Cornelius Feier-Riesen authored 3 years ago and Florian Uhlig committed 2 years ago

add new PLUTO path (Tetyanas folder)
add purity histograms
add histograms to investigate diff. between PLUTO/UrQMD and electron/positron
add CB histograms in LmvmDraw.cxx
add histogram to investigate BG and its sources
add histosgrams for acc and rec. pions and electrons for var. detector
combinations
some more small changes

Fix deprecation warnings about upercase log levels. Use lowercase ones.

Fix ambiguous function call.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

- Move implementation of CbmMuchAddress::SetElementId to cpp file
- Move Logger include from header to cpp
- Add missing Logger include to CbmMuchSignal cxx file
- Add missing Logger include to CbmAnaDimuonAnalysis cxx file (needed only for FS/FR jun19-v18.2)

Induced by inclusion in DigiData of the other detectors on top of STS (needed only for FS/FR higher than FS/FR jun19-v18.2)

Cornelius Feier-Riesen authored 3 years ago and Florian Uhlig committed 3 years ago

and also change nofBins of hTofM2 histogram.