Administrator authored 1 year ago and Florian Uhlig committed 1 year ago

The remaining code in the mvd directory was not used after all the changes.
Move the 2 PDF files to core/detectors/mvd as temporary solution. Finally the
files need a better place.
Remove the complete mvd directory and the usage from the main CMakeLists.txt

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Add build system files for new mvd code structure
Move code from mvd directory to core/detectors/mvd, sim/detectors/mvd,
reco/detectors/mvd and analysis/detectors/mvd.
Create the libraries CbmMvdCore, CbmMvdSim, CbmMvdReco and CbmMvdAna.

This commit will not compile.

Eoin Clerkin authored 2 years ago and Florian Uhlig committed 2 years ago

Record the hash and date of the build and report these at build and configuration times.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Remove obsolete files containing macros which were needed before the build
system was moderinsed. The only macro which is still needed was added in
the file CbmMacros.cmake.

Felix Weiglhofer authored 2 years ago and Florian Uhlig committed 2 years ago

Replace usage of deprecated LIBRARY_OUTPUT_PATH variable with newer CMAKE_LIBRARY_OUTPUT_DIRECTORY.
The new variable has the advantage that it populates the LIBRARY_OUTPUT_DIRECTORY property of targets.
This property is required by xpu to figure out where the generated cuda/hip libraries should be placed.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

Update NicaFemto version which include now all patches.

Omveer Singh authored 2 years ago and Florian Uhlig committed 2 years ago

print_info() macro added to CbmMacro.cmake module
unnecessary variables removed

There were problems reported when a system version of GTest exist which
should be solved with this fix.

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

If using a non FairSoft installation of the dependencies problems were
reported after the last changes to the build system. Instead of hardcoding
the SIMPATH use the the information from ROOT about its binary directory.
Remove some old usage of the root-config script, use CMake variables provided
by ROOT instead.

Linking the MQ TSA  binaries on Debian11 need an additional boost library as
well as a reordering of the link libraries.

Use cmake FindPackage config files instead of the self written FindPackage
module files.
The FindPackage config files are created by the developers themself and
installed with external dependencies.

Add missing CMake variables which are not defined any longer by the self
written FindPackage module files.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

Do some Minor fixes.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Restructure code in the main CMakeLists.txt

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which does some basic checks into separate CMake file.
Some additional reordering of the code is needed.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which defines the compiler settings into separate CMake file.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Move code which defines additional targets into separate CMake file.
Move code which generates the config files into separate CMake file.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Check if environmnet variables SIMPATH and FAIRROOTPATH are set or if the paths
are passed on the commandline as -DSIMPATH=<path to FairSoft installation>
-DFAIRROOTPATH=<path to FairRoot installation> early during the cmake run.
After the initial check only the CMake variables are used.

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Remove obsolete, unneeded and unused code.

The external flesnet requires at least CMake 3.14.0.
Check already in our CMakeLists.txt if this version is available, otherwise
the test is done when building flesnet and the error is hidden in some log
file.
Use CMake from the FairSoft installation on the CI runner (lxir116 )where the
CMake version is to old.

VMC isn't any longer part of ROOT but an external package, so we have to find
it differently. The same problem also appears for NicaFemto such that we fix
the issue with a patch.

Administrator authored 2 years ago and Volker Friese committed 2 years ago

Use C++17 as C++ standard for the compilation of CbmRoot.
Check if compiler supports the C++17 standard.
Check if also FairSoft was compiled with C++17.
Check the required versions of ROOT (at least Root6), FairSoft( at least apr21)
and FairRoot (at leass v18.6.7).
If any of the checks fail stop the configuration with a meaningful error
message.
Remove some switches which are not needed any longer.
Remove checks for C++11 features. No need to check them any longer, since the
new standard is noe C++17.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Patch the AnalysisTree and AnalysisTreeQA buils systems to create also
correct dictionaries for ROOT versions below v6.18.0.
Add the directories where the header files of both packages are installed
to ROOT_INCLUDE_PATH which are paths used by rootcint to find needed
header files.

Before the change it was necessary to define an environment variable to switch
between different test suites like for example the Experimental or Nightly
tests. Now the test suites are chosen by the CMake command line parameter
CBM_TEST_MODEL. These are Experimental, Nightly and Weekly which differ by the
number of executed tests.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Build the algo subdirectory only if C++17 is the chosen c++ standard. The
value depends on the C++ standard used to compile FairSoft.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The new library currently only contains a ROOT free version of CbmStsDigi.
The code is still in core/data/sts. The class CbmStsDigi is currently compiled
twice. Once with ROOT dictionary an streamer in libCbmData and once without
any ROOT dependency in libCbmOnlineData. refs #2258

The clang_format check needs the .git rpository to be present. In the release
tar file the directory is missing which results in a crash when running cmake.

The previous fix did not work for macosx 11.3. Somehow on this system the old
FindGEANT3.cmake file was used.
Probably this is not a problem with the macosx version but with the usage of
a case insensitive file system. To avoid the problem remove the old and
obsolete file.
Also do some fixes to properly initialise some cmake variables.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

With the previous fix the ROOT_INCLUDE_PATH wasn't correct on all platforms.
This is now fixed. refs #2088

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The generated config scripts did not contain the proper (DY)LD_LIBRARY_PATH
information when using FairRoot v18.6. refs #2088

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The current flesnet version contain all changes/patches which we did so far
when compiling CbmRoot.
The new flesnet version also needs un updated version of cppzmq.
refs. #2068, #2069