Lena Rossel authored 1 year ago and Florian Uhlig committed 1 year ago

Add missing break statements (Dennis Spicker)

Without these break statements,
the resulting gamma would always be
the one for the highest Bethe-Bloch value.

Fix calculation of gamma (Lena Rossel)

Change speed of light to 1.
Momentum and mass are given in GeV, therefore speed of light does not need to be c=3e8.

Eoin Clerkin authored 1 year ago and Florian Uhlig committed 1 year ago

As reported in #2913, G4 Commands for Cerenkov photons were defunct
with current FS G4 version.

(CbmTrdParModAsic) and the proper set related. Add also CROB id to the
param file

Administrator authored 1 year ago and Florian Uhlig committed 1 year ago

Remove all usage of cout.
Use the FairLogger instead.
Fix copyright statement.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Remove commented code.
Move library dependency from public to private.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Use vectors instead of fixed size arrays.
Adapt code to properly use the new buffer class.

Michael Deveaux authored 2 years ago and Florian Uhlig committed 1 year ago

First adaptations for a time based digitizer. Methods added but not used in CbmMvdDigitizerTask and CbmMvdDataSheet

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Update license header.
Use nullptr instead of macro NULL.
Remove path from include statements.
Add missing include statements and remove unneeded ones.
Use forward declaration whenever possible.
Remove obsolete functions.
Move cout to LOG.
Remove some unnecessary code.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Remove function SetProduceNoise from CbmMvdSensor and CbmMvdDetector. The
function from the plugin is now called directly from the digitizer.
Exchange some casts to the final taks by using the base class instead.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Add build system files for new mvd code structure
Move code from mvd directory to core/detectors/mvd, sim/detectors/mvd,
reco/detectors/mvd and analysis/detectors/mvd.
Create the libraries CbmMvdCore, CbmMvdSim, CbmMvdReco and CbmMvdAna.

This commit will not compile.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

Comment set but unused variables in much code.

With FairRoot v18.8 the functions GetOutputFile() and SetOutputFile() are
deprecated instead of using a file sink. Correct user code to create the
file sink correctly or to extract the file name from the file sink.
Comparisons of results before and after the change showed that the results
are absolutely identical.

The function sprintf is marked deprecated with the latest Clang version.
Move from sprintf to snprintf. Define and use buffer size.
Check the return value in a function where this is important.

- Add usage of address field to TzdDigi
- Conversion constructor from TOF to TZD digis
- Conversion constructor from TZD to TOF digis
- Serializer and dictionary for TZD digi
- Adapt Tzd Digitizer to provide default value for new address field

Create and store matches for the psd detector system.

The ideal event builder relies on existing match objects. If the matches are
not available the detector system is excluded from the event building such
that at later stages no digis for this detector system ar present and no hits
are produced.

Fixes #2665.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Use the same target names as provided by FairRoot with version v18.8.

Add the new target FairRoot::Online which is a new library conatining the
online related code which was previously part of the Base library.
In case of older FairRoot versions the target is only an alias for the target
FairRoot::Base such that the same dependencies already work with FairRoot
v18.6 which is our current default version.

Add the new target FairRoot::Online in all CMakeLists.txt where it is needed.

The FindFairRoot macro is also used when compiling NicaFemto. Since there is a
problem with the target definitions in NicaFemto the targets are not defined
when compiling NicaFemto.