Sergei Zharko authored 1 year ago and Sergey Gorbunov committed 1 year ago

- Added new library CaCore in cbmroot/algo/ca/core, where the code from cbmroot/reco/L1/L1Algo will be iteratively moved

CA [bugfix]: Fix of TOF matching scheme in CA QA/perforamce; Introduction of a simple event display in CA output QA

Lukas Chlad authored 1 year ago and Florian Uhlig committed 1 year ago

Adding detector-specific FSD hit producer, currently a very simple ideal one - copying data from digi to hit - adding only geometry information of the center and dimension of the FSD module.
Inclusion of FSD into event-building algorithms. Following the templates and just adding cases if the FSD detector objects are processed.
Adding FSD to run_reco macros and also to new compiled reco executable.
Modified CbmFsdHit class, new constructor with all info needed.

Florian Uhlig authored 1 year ago and Administrator committed 1 year ago

The check is disabled since it isn't yet decided if clang-tidy should be
integrated in the CI chain.

The target will run clang-tidy on all changed source and header files
The target is only created if the used clang-tidy supports all required
checks. The required checks will be extracted from the clang-tidy configuration
file, so the list should be alwyas correct.

Instead of having a hardcoded list of required checks the list is extracted
from the clang-tidy config file such that the list is always up to date.

Add CMake script to execute the TidyCheck in our CI

Download and install external packages needed when running clang-tidy.
To speed up things execute clang-tidy in parallel on differnt files if more
cores are available.

Add shell script used by the CMake target

Check changed header files only if there is a corresponding source file in the
compile_commands database. Currently there is no way to test header files
without corresponding source file (compilation unit).
Create missing but expected output directories.
Remove clang-tidy command line option
The option was moved to the config file.

The script find_files.sh is now used from two places so pass the required
information as parameters. Remove one unneded parameter

The script allows to run clang-tidy on the complete project by passing the path
to the CbmRoot source directory or only a subdirectory by passing the path to
the subdirectory.
Some of the compilation units should not be tested by clang-tidy.
Exclude checking the dictionaries G__*.cxx since they generated by root-cling.
Exclude all targets from the external directory. This isn't our code and must
not be checked by us.

The format works for clang-tidy version 11 and 16.
Use clang-format automatically after running clang-tidy to also format the
changed file.
Add modernize-deprecated-headers check which warns about old C header files.

Add the sytem compiler include paths needed for our static standalone
clang-tidy binary to the list of include paths.
The paths are only added to the compilation units in the generated file
compile_commands.json which is used as input for clang-tidy. Without the
paths clang-tidy can't find the standard C and C++ header files.

The geometries, parameters and input data are not needed when running
clang-tidy, so don't waste time downloading them.
The still downloaded projects include header files which are used by CbmRoot
classes. If these header files are not found by clang-tidy the check of some
compilation units fail.

Use VC in scalar mode, otherwise system and hardware related header files are
needed which couldn't be found.
Fix an issue with an missing header file in KFParticle when using the scalar
VC version.

Eoin Clerkin authored 1 year ago and Florian Uhlig committed 1 year ago

Convert names of Material/Media into unique index numbers to
avoid Geant4, FairRoot and CbmRoot mixing media swapping.

- point station index definition in the performance
- rejection of hits with NaN or Inf parameters
- transport macro with box generator for mCBM

The target is not available in newer FairMQ versions.