definition. Details include:
- global access to the masking status (CbmTrdModuleAbstract)
- implementation of channel masking (CbmTrdParFasp)
- updates in the R/W of FASP parameters (CbmTrdParSetAsic)
- documentation for the ASIC param class (bmTrdParAsic.h)
- online monitoring of mask/working channels (CbmTrdUnpackFaspMonitor)

Administrator authored 1 year ago and Florian Uhlig committed 1 year ago

Initialize the data members in the header file and use default constructor and
default destructor.

Administrator authored 1 year ago and Florian Uhlig committed 1 year ago

Remove all usage of cout.
Use the FairLogger instead.
Fix copyright statement.

Administrator authored 1 year ago and Florian Uhlig committed 1 year ago

The remaining code in the mvd directory was not used after all the changes.
Move the 2 PDF files to core/detectors/mvd as temporary solution. Finally the
files need a better place.
Remove the complete mvd directory and the usage from the main CMakeLists.txt

Michael Deveaux authored 2 years ago and Florian Uhlig committed 1 year ago

First adaptations for a time based digitizer. Methods added but not used in CbmMvdDigitizerTask and CbmMvdDataSheet

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Update license header.
Use nullptr instead of macro NULL.
Remove path from include statements.
Add missing include statements and remove unneeded ones.
Use forward declaration whenever possible.
Remove obsolete functions.
Move cout to LOG.
Remove some unnecessary code.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Remove function SetProduceNoise from CbmMvdSensor and CbmMvdDetector. The
function from the plugin is now called directly from the digitizer.
Exchange some casts to the final taks by using the base class instead.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Add build system files for new mvd code structure
Move code from mvd directory to core/detectors/mvd, sim/detectors/mvd,
reco/detectors/mvd and analysis/detectors/mvd.
Create the libraries CbmMvdCore, CbmMvdSim, CbmMvdReco and CbmMvdAna.

This commit will not compile.

Pierre-Alain Loizeau authored 1 year ago and Florian Uhlig committed 1 year ago

- cf https://github.com/root-project/root/issues/12242
- Fixes edge case of #2620 which was missed by previous patch: Assemblies which are not PhysicalNodes were not recomputed if not touched

The function sprintf is marked deprecated with the latest Clang version.
Move from sprintf to snprintf. Define and use buffer size.
Check the return value in a function where this is important.

Alexandru Bercuci authored 2 years ago and Florian Uhlig committed 2 years ago

sets and to take into account the alignment

CbmTofInteraction class is introduced to address the problem of multiple MC points for one interaction.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Pierre-Alain Loizeau authored 2 years ago and Florian Uhlig committed 2 years ago

Should be removed once proper fix is done in FairRoot or Root and we switch to a version including it

unnecessary commands removed which oprated a directory level.
like include_directories() link_directories()
Now operating on the target directory using target_include_directories()
target_link_libraries() commands.
generating library target using generate_cbm_library() macro provided by us.

L1: U and V coordinates and uncertainties conversion methods were refactored and moved from L1Algo to L1Station