Administrator authored 1 year ago and Sergey Gorbunov committed 1 year ago

Add CbmMvdQa to the reconstruction test to create residuals for the MVD.
Small fixes in CbmMvdQa to get the task running again. Attach tracks only of
requested. Fix issue when writting the output.

Add protections when tracking and/or track matching delivers strange results.

Frederic Julian Linz authored 1 year ago and Florian Uhlig committed 1 year ago

This MR introduced minor updates to the cbmreco_offline and cbm_atconverter binary: 
- colored log ouput 
- forward declaration of classes in header files 
- new function to get cbmsim tree from file 
- use consistently "firstTs" and "numTS" to set start event and number of processed events, respectively -STS track matching

Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

Oleksii Lubynets authored 1 year ago and Florian Uhlig committed 1 year ago

MC-true pdg code field was removed from VtxTracks branch long back in time.
This information is available via AT::Matching. 
The commented piece of code and empty (filled with zeros) field mc_pdg still remained
which was fixed with this MR.

- Add protection in CheckParticleSource for Tracks without MC Track
- Add label for EventStartTime variable
- Fix mass dependent weighting for single tracks from thermal source
- Fix typo in mother pdg for qgp radiation
- Fix weighting of pluto particles from different mothers
- Fix mass dependent scaling for comb. pairs from thermal sources
- Assign mctrack pointer directly instead of creating it as nullptr first
- Move include TClonesArray outside of ifndefin PairAnalysisMC, remove from PairAnalysisPair
- Dont define MCtrack as nullptr but assign it directly
- Change uses of 0x0 to nullptr

See !1261 for original description and discussion

Administrator authored 1 year ago and Florian Uhlig committed 1 year ago

Remove all usage of cout.
Use the FairLogger instead.
Fix copyright statement.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Update license header.
Use nullptr instead of macro NULL.
Remove path from include statements.
Add missing include statements and remove unneeded ones.
Use forward declaration whenever possible.
Remove obsolete functions.
Move cout to LOG.
Remove some unnecessary code.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Add build system files for new mvd code structure
Move code from mvd directory to core/detectors/mvd, sim/detectors/mvd,
reco/detectors/mvd and analysis/detectors/mvd.
Create the libraries CbmMvdCore, CbmMvdSim, CbmMvdReco and CbmMvdAna.

This commit will not compile.

With FairRoot v18.8 the functions GetOutputFile() and SetOutputFile() are
deprecated instead of using a file sink. Correct user code to create the
file sink correctly or to extract the file name from the file sink.
Comparisons of results before and after the change showed that the results
are absolutely identical.

Frederic Julian Linz authored 2 years ago and Florian Uhlig committed 2 years ago

Check cbm_header init before using it.
Added runtime error for MCEventList.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.