Dominik Smith authored 3 years ago and Florian Uhlig committed 3 years ago

Moved CbmStsDigitizeQa, CbmStsDigitizeQaReport and CbmStsFindTracksQa to qa subfolders. Updated CMakeLists.txt accordingly.

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

From FairRoot version v18.4.0 on the function CheckIfSensitive() of the class
FairModule is deprecated and replaced by the function IsSensitive(). The old
function is still available but usage results is a compilation error.
To be able to use FairRoot v18.2.1 and newer versions both functions are
implemented in the CbmRoot code where the old function simply forwards to the
new one. If there is no need to support older FairRoot versions the old
function can be simply removed from the source code.

Pascal Raisig authored 3 years ago and Volker Friese committed 3 years ago

Integration of TRD unpacking, with empty implementations for unpacker, monitor container and parameter container.

Somehow /usr/loacl/lib isn'T any longer in the default link path such that
libfreetype isn't found.

Unify user names in the license header authors list.
Remove duplicate users in the authors list.
Cleanupo of some other inor issues.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

Add missing include statements.
With FairSoft apr21 and/or FairRoot v18.6.2 some implicitly included
header files aren't found any longer. Add include statements for these
header files explicitly.

The class FairLogger is  meanwhile only a wrapper around the Logger class,
so use the Logger directly. This also helps to reduce many warnings when
using the Eclipse IDE.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Up to now the ROOT random number generator was always initialised with the
same default value. In some cases this gives strange results when doing
large scale simulations with several jobs.
To solve the problem TRandom is now initialised with the value 0 which uses a
seed value based on the system time with a granularity of 100ns.
This granularity should be good enough to have different seed values even if
several jobs start a similar times on the batch farm.
A setter was added to allow to set the seed value explicitly from a macro,
refs #1395, #2066

Administrator authored 4 years ago and Florian Uhlig committed 3 years ago

On macosx one needs a openmp installation which does not come with the system,
at least the omp.h header file is missing. brew has a package libomp which
installs the header and a library. Both are found by the cmake module
FindOpenMP and properly used during the compilation and linking.
In themoment there is still a runtime error when executing the L1 tracking
with OpenMP support on macosx, so switch off OpenMP for the time being.
The problem is investigated already. refs #2028.

Cleanup OpenMP handling in the build system. Move check for OpenMP to top
level. Remove OpenMP usage from all libs were it is not needed.

Don't use tof digi parameter file any longer in the digitization step.
The needed information is meanwhile taken from the TGeoManager.

Initialize tof geometry parameters in the simple clusterizer from the
TGeoManager, as it is already done in the event clusterizer and the digitizer.

Add a special case in the TofGeoManager for the tof_v20a geometry.
The geometry has to be treated as v14a.