Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C cbmroot
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Om
  • cbmroot
  • Merge requests
  • !3

Fix OpenMP issue on macosx and implement proper dependencies

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Florian Uhlig requested to merge f.uhlig/cbmroot:mr-upstream-955 into cmake_ana_dev Oct 31, 2022
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 10

OpenMP comes with the proper targets which are used now.

Implement proper dependencies

With the change to the CMake targets the dependency tree was broken. The generation of the ROOT dictionary is now a target on its own which did not depend on anything except the header files needed for the specific library. Some of these header files include other header files from the external libraries. The problem was that now it became possible that the dictionary generation started before the external header files were available.

Add explicit dependencies from these dictionaries to the external libraries.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mr-upstream-955