Skip to content
Snippets Groups Projects

Transition to Modern CMake (analysis Dir)

Merged Omveer_Singh requested to merge om/cbmroot:cmake_ana_dev into master
All threads resolved!

CMakeList.txt files are modified according to modern CMake. generate_cbm_library() macro is used to make target. Imported targets of each package are used as dependencies.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @osingh,

    probably the failing tests are due to the fact that NicaFemto isn't properly installed yet when trying to build some libraries. Could you please try to add the

    add_dependencies()

    statements again.

  • Author Reporter

    @f.uhlig I have already tried the same. It doesn't work for me.

  • Author Reporter

    @f.uhlig If I define the direct dependency on the target like Add_Dependencies(NicaCbmCuts NicaFeatures) then It works. If I replace NicaFeatures with NICAFEMTO, It doesn't work.

  • @osingh,

    then please use the dependency to NicaFeatures if this works.

  • Author Reporter

    It worked once when I complied again, the same problem arose. KFParticle is also not correctly installed when trying to build some libraries depending on it.

  • Omveer_Singh added 2 commits

    added 2 commits

    • a39e0b9f - Fix OpenMP issue on macosx
    • 67b138bd - Implement proper dependencies

    Compare with previous version

  • Omveer_Singh added 13 commits

    added 13 commits

    Compare with previous version

  • Florian Uhlig added 4 commits

    added 4 commits

    • b27b1160 - 1 commit from branch computing:master
    • c2a3a573 - Transition to Modern CMake (analysis Dir)
    • c8b4ccec - Fix OpenMP issue on macosx
    • 4ca28621 - Implement proper dependencies

    Compare with previous version

  • Florian Uhlig approved this merge request

    approved this merge request

  • Florian Uhlig resolved all threads

    resolved all threads

  • Florian Uhlig enabled an automatic merge when the pipeline for 4ca28621 succeeds

    enabled an automatic merge when the pipeline for 4ca28621 succeeds

  • Dear @wielanek_AT_if.pw.edu.pl, @i.selyuzhenkov, @c.pauly, @a_meye37_AT_uni-muenster.de, @karpushkin_AT_inr.ru, @v.friese, @n.herrmann, @i.deppner, @se.gorbunov, @v.akishina,

    you have been identified as code owner of at least one file which was changed with this merge request.

    Please check the changes and approve them or request changes.

  • merged

  • Please register or sign in to reply
    Loading