TRD contribution for MR863
All threads resolved!
All threads resolved!
fix requested for MR !863 (closed)
Edited by Alexandru Bercuci
Merge request reports
Activity
Filter activity
@a_meye37_AT_uni-muenster.de This is my fix. Yours are already in master or ?!
- Resolved by Alexandru Bercuci
Hi Alex! No, my changes were commited and pushed to this branch (fix_warning_trd). I think you may have accidentally overwritten them with a rebase or something. They are still in my local git repository (see my gitlog below), so I will try to apply them again to the rebased branch. Maybe you should mark this MR as draft for the time being ;)
commit 99b323235325e8887406072507a56c6e7c8e3642 Author: Adrian Meyer-Ahrens <a_meye37@uni-muenster.de> Date: Wed Sep 14 13:58:20 2022 +0200 comment out variable which is only used for qa output commit c471d776409205890cd962bbe4358aa41eb4e350 Author: Adrian Meyer-Ahrens <a_meye37@uni-muenster.de> Date: Thu Sep 8 12:32:16 2022 +0200 Lookup Mode 2 should use sum of samples instead of MaxADC, even though the mode is not fully implemented yet commit 44cb4f82ea43b268696179aac4143345d9e7a259 Author: Adrian Meyer-Ahrens <a_meye37@uni-muenster.de> Date: Wed Sep 7 17:11:43 2022 +0200 remove unused sum variable commit 9584f3afc1cf013de258f1c8036a4ec3cca9a3fc Author: P.-A. Loizeau <p.-a.loizeau@gsi.de> Date: Fri Aug 5 15:46:37 2022 +0200 Fix for run_digi crash at exit, to be solved better on FairRoot side
Edited by Adrian Meyer-Ahrens
added 1 commit
- 54d91638 - Fix remaining unused variables for trd related files
Dear @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Alexandru Bercuci
Can the MR be merged now?
Please register or sign in to reply