Skip to content
Snippets Groups Projects

Bugfix: Protection against out-of-sequence timeslice reading in CbmSourceTs.

Merged Dominik Smith requested to merge d.smith/cbmroot:CbmSourceTsFix into master
All threads resolved!

Added protection against out-of-sequence timeslice reading to CbmSourceTs::ReadEvent(). This is not supported but could previously be requested by the user, leading to unexpected behavior.

Fixes issue #2580

See redmine for further details and discussions.

@v.friese @f.uhlig

Edited by Pierre-Alain Loizeau

Merge request reports

Merge request pipeline #19146 passed

Merge request pipeline passed for bfcd018f

Approved by

Merged by Florian UhligFlorian Uhlig 2 years ago (Sep 28, 2022 12:53pm UTC)

Merge details

  • Changes merged into master with bfcd018f.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #19148 passed

Pipeline passed for bfcd018f on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dominik Smith added 4 commits

    added 4 commits

    • 0146ae07...44db5a9d - 3 commits from branch computing:master
    • ccb49818 - Added protection against out-of-sequence timeslice reading to...

    Compare with previous version

  • Florian Uhlig resolved all threads

    resolved all threads

  • Florian Uhlig approved this merge request

    approved this merge request

  • Pierre-Alain Loizeau changed the description

    changed the description

  • Just as a warning: as far as I know fFlesSource->get() loads the TS in memory from whatever source is in use, so even if this allows you to skip the processing part of the chain, this may still take a while as the disk access remains (e.g. for really big TS on lustre or on laptop's HDDs).

    So maybe that should be printed out when this mode is detected before the first iteration of the loop/while, something like "Skipping N timeslices to reach desired start point (current XXXX, desired YYYY), this may take a while"

  • Dominik Smith added 45 commits

    added 45 commits

    • ccb49818...83813639 - 44 commits from branch computing:master
    • fb72481b - Added protection against out-of-sequence timeslice reading to...

    Compare with previous version

  • @p.-a.loizeau I added a warning message.

  • Florian Uhlig added 13 commits

    added 13 commits

    • fb72481b...8827e456 - 12 commits from branch computing:master
    • d72cf651 - Added protection against out-of-sequence timeslice reading to...

    Compare with previous version

  • Florian Uhlig added 16 commits

    added 16 commits

    • d72cf651...689e844e - 15 commits from branch computing:master
    • bfcd018f - Added protection against out-of-sequence timeslice reading to...

    Compare with previous version

  • Florian Uhlig enabled an automatic merge when the pipeline for bfcd018f succeeds

    enabled an automatic merge when the pipeline for bfcd018f succeeds

  • merged

  • Please register or sign in to reply
    Loading