fix memory leak reported at https://redmine.cbm.gsi.de/issues/2570.
Extend suggestions of PAL. Move MR from the mCBM fork to cbmroot master.
PAl edit: Refs #2570
Merge request reports
Activity
Dear @f.uhlig, @v.friese, @p.-a.loizeau, @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
requested review from @p.-a.loizeau
- Resolved by Florian Uhlig
beside my two comments the MR looks ok for me. Nevertheless I would like to get an okay also from Pierre since he is more familiar with the unpacker codes. If he does not approve I will merge the MR anyway after the weekend since it blocks data analysis.
Edited by Florian Uhlig - Last reply by Florian Uhlig
mentioned in commit a.bercuci/cbmroot@88d542a7
added 9 commits
-
65b45610...43810837 - 7 commits from branch
computing:master - 5b16d30c - fix memory leak reported at https://redmine.cbm.gsi.de/issues/2570.
- 88d542a7 - apply suggestions of FU !918 (comment 23641)
-
65b45610...43810837 - 7 commits from branch
mentioned in merge request CbmSoft/cbmroot_parameter!102 (merged)
added 1 commit
- e31d6ea2 - replace "push_back" call with "emplace_back" for increased performance
enabled an automatic merge when the pipeline for e31d6ea2 succeeds
added 1 commit
- 87d2c670 - update hash for MR CbmSoft/cbmroot_parameter!102 (merged)
enabled an automatic merge when the pipeline for 87d2c670 succeeds
For redmine reference linking: Refs #2570
Edited by Pierre-Alain Loizeau