Skip to content

Cleanup of CbmTofUnpackAlgo.

Dominik Smith requested to merge d.smith/cbmroot:UnpackTofCleanup into master

Refactored and cleaned up CbmTofUnpackAlgo.

@p.-a.loizeau @f.uhlig

Some global fields were removed, some functions broken up into smaller units, some unneeded lines deleted, Root types removed etc. The changes introduced here make the code subjectively more readable. I leave it up to the experts whether to merge this or not. This is preliminary work for the implementation of a Tof unpacker in the Algo namespace and was mainly done to make this task simpler.

So far, the changed class has not been tested.

There are some compiler warnings about integer types:

/home/dsmith/cbmroot/reco/detectors/tof/unpack/CbmTofUnpackAlgo.cxx:410:43: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
  410 |                << Form("Raw Epoch: 0x%06llx, Epoch offset 0x%06llx, Epoch in Ts: 0x%07lx, time %f ns (%f * %lu)",
...

Merge request reports