Fix segfault on exit of macros: unpacking and digitization

1. Deletion of source pointer already present at l.145 of the FairRootManager (source), so we should not do it ourselves in CbmDigitization
2. There is a problem with ownership and pointer deletion of ROOT objects attached to the ROOT global lists when shared pointers are used: if the owners count does not reach 0 before the end of the root session, ROOT "cleans out" the objects in its lists before the end of scope, so any destructor trying to be nice an clean memory it allocated for such objects and never made public will trigger a segmentation violation
   • List of ParAsic in the StsUnpackConfig class sub-members, due to the internal TF1
   • List of histograms and canvases in the UnpackMonitor classes of STS, MUCH, TRD, TOF and RICH

For the TF1 a trick was found to tell ROOT to ignore them.

requested review from @v.friese

assigned to @f.uhlig

changed the description

added 3 commits

• 2823ca08 - In unpack monitors, protect hist/canv creation from current root folder pb
• 66d94270 - In StsParAsic/Module, rem move methods + protect TF1 name and creation folder
• 4d63c887 - ../commit_msg.txt

Compare with previous version

changed the description

added 2 commits

• 233f1035 - In StsParAsic/Module, rem move methods + protect TF1 name and creation folder
• 945dd2a7 - Fix segfault at exit of unpacking macros

Compare with previous version

marked this merge request as ready

changed title from WIP: Fix segfault on exit of macros to Fix segfault on exit of macros: unpacking and digitization

added 2 commits

• a22af7dd - In StsParAsic/Module, rem move methods + protect TF1 name and creation folder
• 831129ee - Fix segfault at exit of unpacking macros

Compare with previous version

added 2 commits

• 43b76290 - In StsParAsic/Module, rem move methods + protect TF1 name and creation folder
• 594090bf - Fix segfault at exit of unpacking macros

Compare with previous version

mentioned in merge request !672 (closed)

Dear @v.friese, @f.uhlig, @p.-a.loizeau, @v.singhal, @s.lebedev, @n.herrmann, @i.deppner, @a.bercuci, @p.kaehler,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 4 commits

• 2bdc54c9 - In StsParAsic/Module, rem move methods + avoid storing TF1 in ROOT global list of fctns
• bcd908c6 - Fix segfault at exit of unpacking macros
• d72b0782 - Added segmentation fault error condition to cmake tests.
• d5af4b0a - Don't store function in the global list of functions

Compare with previous version

changed the description

approved this merge request

merged