Skip to content
Snippets Groups Projects

Fix spadic ch mapping

Merged Pascal Raisig requested to merge trd/cbmsoft/cbmroot:fixSpadicChMapping into master
All threads resolved!

There was a change of the asic to feb channel mapping between the spadic 2.0 and 2.2. This change was not taken into account before. The commits fix this issues for the parameter creation.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pascal Raisig added 12 commits

    added 12 commits

    • 6abb92d2 - add AT->KFPF interface
    • c38c36ec - make 100% reproducing original KFPF
    • 60448689 - add PV from reco to CbmKFPF
    • ba2a2f91 - add macro
    • fa155919 - fix bug with PV find mode
    • f2a932ae - clang formating
    • d7fc4678 - unformat CmakeLists.txt to avoid bug
    • 37a954b5 - add macro test, fix macro
    • 4bb5ef29 - fix typo in output file name
    • f9b44b00 - fix macro test, return PV find mode default
    • cc128cb9 - apply clang for macro
    • 93f5c2c5 - Improve performance by initializing the channel vector in the header

    Compare with previous version

  • Pascal Raisig added 14 commits

    added 14 commits

    • 93f5c2c5...bc6809b4 - 11 commits from branch computing:master
    • f77423be - Fix spadic 2.2 channel mapping in asic coordinates
    • 60e9e9fe - Second iteration of mapping fix
    • 71a72fb1 - Improve performance by initializing the channel vector in the header

    Compare with previous version

  • Pascal Raisig resolved all threads

    resolved all threads

  • Hi @praisig,

    I stopped the pipeline since something is wrong with your last update of the MR. Somehow the order of the commits is wrong. The commits from Oleksii are in between you first two commits and the last one. I think something went wrong with the rebase command.

    Okay, while writing the comment I see that you have fixed it. Could you explain what you did?

  • I used the rebase button here on the page.

  • Florian Uhlig resolved all threads

    resolved all threads

  • Pascal Raisig added 4 commits

    added 4 commits

    • 862a44d6 - 1 commit from branch computing:master
    • 6bd1700e - Fix spadic 2.2 channel mapping in asic coordinates
    • 66d49200 - Second iteration of mapping fix
    • ce32d13a - Improve performance by initializing the channel vector in the header

    Compare with previous version

  • Florian Uhlig resolved all threads

    resolved all threads

  • Pascal Raisig resolved all threads

    resolved all threads

  • Florian Uhlig approved this merge request

    approved this merge request

  • merged

  • Please register or sign in to reply
    Loading