Changes from mCBM 2022 prod to RICH unpack, reco and monitor
Follow-up MR of !876 (merged)
Edited by Pierre-Alain Loizeau
Merge request reports
Activity
added Reconstruction mCBM labels
mentioned in merge request !878 (merged)
added 26 commits
-
d881f43b...26080ec4 - 5 commits from branch
computing:master
- 1b4bcb38 - [REPO] Set externals to point to latest version
- cdcafeaa - In macro/mcbm/matbudget_sim.C, change default setup and fix line offsets
- e79b3242 - Changes to mcbm_transport macro:
- 6c60d616 - Add NT Correlation Plot to TRD Online Monitor
- 2a226f91 - Add Message Rate Timeplots to TRD Monitor
- 7ea221c8 - add support for multiple CRI boards in the TRD2D detectors
- 18348085 - add digi buffering to fix asynchronous ADC read-out. Restore PRF for
- 5bb20ce4 - update for TRD reco also in the mCBM fork
- 3237800a - [Evt Builder] Restore and expand support for T0 digis in TOF vector
- 0818695d - In EventBuilderAlgo, fix bug preventing to use max Digi Nb for anti-trigger
- faa240de - In EventBuildRawTask, add setter for min nb of layers
- 57bca1bd - [Evt Builder] Fix string comp in filling of separate histos for TRD 1D and 2D
- 4432ad74 - [Evt Builder] in AlgoBuildRawEvent, check each det directly after building it and reject early
- 8a791048 - [Evt Builder] in AlgoBuildRawEvent, add performance plots (time and data red.)
- 0516f9de - [Evt Builder] in BuildRawEvent algo + task, add setter per det for max Digi Nb in histos
- 39e52036 - [Task unpacker] in steering class, add performance plots (time and data exp.)
- 383a47d8 - [TOF] Add TimeOffset getters and direct setter in Unpack templates
- 7f687d90 - In UnpackConfig templ, make GetUnpacker return native type ptr instead of specialized base ptr
- 0c2b376d - [mBMON] Fix/adapt to the new 16ch diamond while keeping old data support
- fbd451ba - add updated rich analysis + macros
- f3453826 - more plots in RICH QA
Toggle commit list-
d881f43b...26080ec4 - 5 commits from branch
Dear @n.herrmann, @i.deppner, @s.lebedev, @f.uhlig, @v.friese, @p.-a.loizeau, @d.smith,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
assigned to @p.-a.loizeau
added 7 commits
-
062d4c39 - 1 commit from branch
computing:master
- 48f38b56 - [Task unpacker] in steering class, add performance plots (time and data exp.)
- ecdaba7f - [TOF] Add TimeOffset getters and direct setter in Unpack templates
- 30157d71 - In UnpackConfig templ, make GetUnpacker return native type ptr instead of specialized base ptr
- 35ed85cd - [mBMON] Fix/adapt to the new 16ch diamond while keeping old data support
- d0e4cb0c - add updated rich analysis + macros
- 3feb8b36 - more plots in RICH QA
Toggle commit list-
062d4c39 - 1 commit from branch
for me the MR looks fine. I did not check the macros since they are RICH internal. The changes in the code are only in some QA classes mostly adding new histograms. Even if there are errors the changes shouldn't affect the simulation, reconstruction or analysis.
Please register or sign in to reply